From: Ralf Baechle <ralf@linux-mips.org>
To: "Maciej W. Rozycki" <macro@imgtec.com>
Cc: "Paul Burton" <paul.burton@imgtec.com>,
linux-mips@linux-mips.org,
"Steven J. Hill" <Steven.Hill@imgtec.com>,
"Joshua Kinard" <kumba@gentoo.org>,
linux-kernel@vger.kernel.org, "Rafał Miłecki" <zajec5@gmail.com>,
"James Hogan" <james.hogan@imgtec.com>,
"Markos Chandras" <markos.chandras@imgtec.com>
Subject: Re: [PATCH] MIPS: tlb-r4k: panic if the MMU doesn't support PAGE_SIZE
Date: Fri, 12 Feb 2016 11:57:36 +0100 [thread overview]
Message-ID: <20160212105736.GA11854@linux-mips.org> (raw)
In-Reply-To: <alpine.DEB.2.00.1602111931450.15885@tp.orcam.me.uk>
On Thu, Feb 11, 2016 at 07:37:12PM +0000, Maciej W. Rozycki wrote:
> > > index 08318ec..4330315 100644
> > > --- a/arch/mips/mm/tlb-r4k.c
> > > +++ b/arch/mips/mm/tlb-r4k.c
> > > @@ -486,6 +487,10 @@ static void r4k_tlb_configure(void)
> > > * be set to fixed-size pages.
> > > */
> > > write_c0_pagemask(PM_DEFAULT_MASK);
> > > + back_to_back_c0_hazard();
> > > + if (read_c0_pagemask() != PM_DEFAULT_MASK)
> > > + panic("MMU doesn't support PAGE_SIZE=0x%lx", PAGE_SIZE);
>
> I think it would make sense to report here what the minimum/maximum page
> size actually supported is, so that the users know what there might be
> after.
This is a very unlikely error condition to be hit so I'd rather keep it
simple. Even just BUG_ON() would suffice.
Ralf
next prev parent reply other threads:[~2016-02-12 10:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-13 16:12 [PATCH] MIPS: tlb-r4k: panic if the MMU doesn't support PAGE_SIZE Paul Burton
2016-02-10 22:10 ` Paul Burton
2016-02-11 19:37 ` Maciej W. Rozycki
2016-02-12 10:57 ` Ralf Baechle [this message]
2016-02-12 16:34 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160212105736.GA11854@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=Steven.Hill@imgtec.com \
--cc=james.hogan@imgtec.com \
--cc=kumba@gentoo.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=macro@imgtec.com \
--cc=markos.chandras@imgtec.com \
--cc=paul.burton@imgtec.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).