From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751513AbcBMVtr (ORCPT <rfc822;w@1wt.eu>);
	Sat, 13 Feb 2016 16:49:47 -0500
Received: from aserp1040.oracle.com ([141.146.126.69]:23378 "EHLO
	aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751306AbcBMVtq (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 13 Feb 2016 16:49:46 -0500
Date: Sun, 14 Feb 2016 00:49:32 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Niranjan Dighe <niranjan.dighe@gmail.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>,
        Andreas Dilger <andreas.dilger@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Shivani Bhardwaj <shivanib134@gmail.com>,
        Dmitry Eremin <dmitry.eremin@intel.com>,
        Mike Rapoport <mike.rapoport@gmail.com>,
        Shraddha Barke <shraddha.6596@gmail.com>, Frank Zago <fzago@cray.com>,
        Hatice =?iso-8859-1?Q?ERT=DCRK?= <haticeerturk27@gmail.com>,
        Mike Shuey <shuey@purdue.edu>, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org, lustre-devel@lists.lustre.org
Subject: Re: [PATCH] staging: lustre/lnet: Fix wrong type casting warning
 generated by sparse
Message-ID: <20160213214932.GE32153@mwanda>
References: <20160213180435.GA16246@codebox>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160213180435.GA16246@codebox>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Source-IP: aserv0021.oracle.com [141.146.126.233]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Feb 13, 2016 at 11:34:35PM +0530, Niranjan Dighe wrote:
> diff --git a/drivers/staging/lustre/lnet/selftest/console.c b/drivers/staging/lustre/lnet/selftest/console.c
> index 366211e..64b6a70 100644
> --- a/drivers/staging/lustre/lnet/selftest/console.c
> +++ b/drivers/staging/lustre/lnet/selftest/console.c
> @@ -1461,9 +1461,9 @@ lstcon_statrpc_readent(int transop, srpc_msg_t *msg,
>  
>  	sfwk_stat = (sfw_counters_t __user *)&ent_up->rpe_payload[0];
>  	srpc_stat = (srpc_counters_t __user *)
> -				      ((char *)sfwk_stat + sizeof(*sfwk_stat));
> +				((char __user *)sfwk_stat + sizeof(*sfwk_stat));

This is uglier than necessary.  Do it either like this:

	srpc_stat = (void __user *)sfwk_stat + sizeof(*sfwk_stat);

Or probably it's actually nicer to say:

	srpc_stat = sfwk_stat + 1;

regards,
dan carpenter