From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752683AbcBOAjx (ORCPT ); Sun, 14 Feb 2016 19:39:53 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:53848 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752418AbcBOAju (ORCPT ); Sun, 14 Feb 2016 19:39:50 -0500 Date: Sun, 14 Feb 2016 16:39:49 -0800 From: Greg Kroah-Hartman To: Colin Vidal Cc: "open list:STAGING SUBSYSTEM" , open list Subject: Re: [PATCH v3 5/5] Staging: rtl8188eu/core: make core more readable Message-ID: <20160215003949.GA1276@kroah.com> References: <1455300355-14524-1-git-send-email-colin@cvidal.org> <1455300355-14524-2-git-send-email-colin@cvidal.org> <1455300355-14524-3-git-send-email-colin@cvidal.org> <1455300355-14524-4-git-send-email-colin@cvidal.org> <1455300355-14524-5-git-send-email-colin@cvidal.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1455300355-14524-5-git-send-email-colin@cvidal.org> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 12, 2016 at 07:05:53PM +0100, Colin Vidal wrote: > Signed-off-by: Colin Vidal > --- > drivers/staging/rtl8188eu/core/rtw_iol.c | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/drivers/staging/rtl8188eu/core/rtw_iol.c b/drivers/staging/rtl8188eu/core/rtw_iol.c > index 2e2145c..ba6c492 100644 > --- a/drivers/staging/rtl8188eu/core/rtw_iol.c > +++ b/drivers/staging/rtl8188eu/core/rtw_iol.c > @@ -18,11 +18,7 @@ > > bool rtw_IOL_applied(struct adapter *adapter) > { > - if (adapter->registrypriv.fw_iol == 1) > - return true; > - > - if ((adapter->registrypriv.fw_iol == 2) && > - (!adapter_to_dvobj(adapter)->ishighspeed)) > - return true; > - return false; > + return adapter->registrypriv.fw_iol == 1 || > + (adapter->registrypriv.fw_iol == 2 && > + !adapter_to_dvobj(adapter)->ishighspeed); > } I'm sorry, but this patch does not do what you said it does, it's much harder to read now :( Also, I can't take a patch without a changelog text :( thanks, greg k-h