From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751927AbcBOBUX (ORCPT ); Sun, 14 Feb 2016 20:20:23 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:57743 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751681AbcBOBUW (ORCPT ); Sun, 14 Feb 2016 20:20:22 -0500 Date: Sun, 14 Feb 2016 17:20:21 -0800 From: Greg Kroah-Hartman To: Victor Dodon Cc: linux-kernel@vger.kernel.org, Matthew Dharm , linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net, Gwendal Grignou Subject: Re: [PATCH] usb: storage: make US_DEBUGPX print with LOGLEVEL_DEBUG Message-ID: <20160215012021.GG26844@kroah.com> References: <20160211001343.GA133746@printesoi1.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160211001343.GA133746@printesoi1.mtv.corp.google.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 10, 2016 at 04:13:43PM -0800, Victor Dodon wrote: > The US_DEBUGPX macro uses printk without specifying a kernel log level, so > the default kernel log level is used, which may not match LOGLEVEL_DEBUG > used in usb_stor_dbg. Use printk_emit with LOGLEVEL_DEBUG instead. > > Signed-off-by: Victor Dodon > --- > drivers/usb/storage/debug.h | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) Can you just get rid of US_DEBUGPX() entirely please? It shouldn't be needed anymore, just use usb_stor_dbg() instead. thanks, greg k-h