From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752213AbcBOHE3 (ORCPT ); Mon, 15 Feb 2016 02:04:29 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:58110 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751996AbcBOHE1 (ORCPT ); Mon, 15 Feb 2016 02:04:27 -0500 X-AuditID: cbfee68e-f793c6d00000136c-e8-56c17879aa48 Date: Mon, 15 Feb 2016 16:04:25 +0900 From: Andi Shyti To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Krzysztof Kozlowski , Lee Jones , Laxman Dewangan Subject: Re: [PATCH 0/4] mfd: max77686: Allow the driver to be built as a module Message-id: <20160215070425.GD10719@samsunx.samsung> References: <1455251419-8919-1-git-send-email-javier@osg.samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-disposition: inline In-reply-to: <1455251419-8919-1-git-send-email-javier@osg.samsung.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprLIsWRmVeSWpSXmKPExsWyRsSkSLey4mCYQcMOfYs3b9cwWbx+YWix dN9qFov7X48yWlzeNYfNYsb5fUwObB53ru1h8+htfsfmsaX/LrtH35ZVjB6fN8kFsEZx2aSk 5mSWpRbp2yVwZbzfvIa14C1vxYyzp5kbGH9wdTFyckgImEhcOTKXBcIWk7hwbz1bFyMXh5DA CkaJE6fPs8IU7byzlgkiMYtR4tzDJ4wQzkdGiYPnbjOBVLEIqErcm/gFrINNQFOi6fYPNhBb RMBU4tfaF6wgDcwCBxglNkw/ApYQFgiQePBjP1AzBwcv0IrZO2tAwkICrhLXdp8FO4lXQFDi x+R7YDazgJbE+p3HmSBsaYlHf2ewg9icAm4SvesXMIKMERVQkXh1sB5klYTAOXaJpqbXrBC3 CUh8m3yIBaRGQkBWYtMBZojHJCUOrrjBMoFRbBaSbbOQbJuFZNsCRuZVjKKpBckFxUnpRUZ6 xYm5xaV56XrJ+bmbGIGxdvrfs74djDcPWB9iFOBgVOLhjThzIEyINbGsuDL3EKMp0BUTmaVE k/OBEZ1XEm9obGZkYWpiamxkbmmmJM6bIPUzWEggPbEkNTs1tSC1KL6oNCe1+BAjEwenVANj wevKNM963UbBVC3p2M+b7GPLzqee8ZUyqo9luDn31p0bli9n9UwI+VAsaOe8jCWz81ovw1aD zdn1Gq/VLxn+nWS58M3h5Z+i+j7wpV21m1933eRz/81nLdnlmyPWn96u9rnMx2/ZNFnW2VNE hEq4t/QbG9jbd3ptn/2+l//P8cLHW/dxFQQqsRRnJBpqMRcVJwIAOiSkl7ACAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrFIsWRmVeSWpSXmKPExsVy+t9jQd3KioNhBm82aFm8ebuGyeL1C0OL pftWs1jc/3qU0eLyrjlsFjPO72NyYPO4c20Pm0dv8zs2jy39d9k9+rasYvT4vEkugDWqgdEm IzUxJbVIITUvOT8lMy/dVsk7ON453tTMwFDX0NLCXEkhLzE31VbJxSdA1y0zB+gCJYWyxJxS oFBAYnGxkr4dpgmhIW66FjCNEbq+IUFwPUYGaCBhDWPG+81rWAve8lbMOHuauYHxB1cXIyeH hICJxM47a5kgbDGJC/fWs3UxcnEICcxilDj38AkjhPORUeLgudtgVSwCqhL3Jn5hBbHZBDQl mm7/YAOxRQRMJX6tfcEK0sAscIBRYsP0I2AJYYEAiQc/9gM1c3DwAq2bvbMGJCwk4CpxbfdZ FhCbV0BQ4sfke2A2s4CWxPqdx5kgbGmJR39nsIPYnAJuEr3rFzCCjBEVUJF4dbB+AiPQlQjd s5B0z0LSvYCReRWjRGpBckFxUnquUV5quV5xYm5xaV66XnJ+7iZGcDw/k97BeHiX+yFGAQ5G JR7eiDMHwoRYE8uKK3MPMUpwMCuJ8PqlHwwT4k1JrKxKLcqPLyrNSS0+xGgKDI+JzFKiyfnA VJNXEm9obGJmZGlkbmhhZGyuJM77+P+6MCGB9MSS1OzU1ILUIpg+Jg5OqQbGpfO+Gao+nbVq wW2R9N+7DZf4WLi6KcXevf3lVrOW8JHcGVPL2R8kSj8QuBpyl1nepWtd6qa99kvNVh27351+ /fujYpNL26quB2Q+1Dz8w6hF6I3rw4AvAs+knk39LlhYN+VLaUsoX6ViycEVYZ/CeXdPK19q YOjCcL0rT0nVvtH94IHEWzpPlViKMxINtZiLihMBqxo9XP0CAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I like all the four patches Reviewed-by: Andi Shyti Thanks, Andi On Fri, Feb 12, 2016 at 01:30:15AM -0300, Javier Martinez Canillas wrote: > Hello, > > The Maxim77802 PMIC driver uses a boolean Kconfig symbol but there isn't > really a reason to require the driver to be built-in. > > It is true that since the PMIC provides clocks and regulators that could > be critical on a system, most integrators are not going to build it as a > module but it could be useful for multi-platform or distribution kernels > that support different systems by building as much as possible as module. > > Besides this series, a patch for the max77686 regulator driver is needed > or the MFD max77686 driver module won't be installed by kbuild. I didn't > include the patch in this series to avoid cross-subsystems churn for the > maintainers and also because I don't consider that a regression since it > was not possible to build the driver as a module before anyways. > > Also, all the defconfigs in mainline that enable the MFD max77686 driver > Kconfig symbol are using =y of course so it shouldn't be an issue to get > this set merged, before the max77686 regulator patch already posted [0]. > > [0]: https://patchwork.kernel.org/patch/8287431/ > > Best regards, > Javier > > > Javier Martinez Canillas (4): > mfd: max77686: Add max77802 to I2C device ID table > mfd: max77686: Use module_i2c_driver() instead of subsys initcall > mfd: max77686: Allow driver to be built as a module > mfd: max77686: Export OF module alias information > > drivers/mfd/Kconfig | 4 ++-- > drivers/mfd/max77686.c | 15 +++------------ > 2 files changed, 5 insertions(+), 14 deletions(-) > > -- > 2.5.0 >