From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752507AbcBOIVN (ORCPT ); Mon, 15 Feb 2016 03:21:13 -0500 Received: from mail-wm0-f51.google.com ([74.125.82.51]:34081 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752298AbcBOIVI (ORCPT ); Mon, 15 Feb 2016 03:21:08 -0500 Date: Mon, 15 Feb 2016 08:21:02 +0000 From: Lee Jones To: Krzysztof Kozlowski Cc: Javier Martinez Canillas , linux-kernel@vger.kernel.org, Andi Shyti , linux-samsung-soc@vger.kernel.org, Laxman Dewangan Subject: Re: [PATCH 2/4] mfd: max77686: Use module_i2c_driver() instead of subsys initcall Message-ID: <20160215082102.GB3455@x1> References: <1455251419-8919-1-git-send-email-javier@osg.samsung.com> <1455251419-8919-3-git-send-email-javier@osg.samsung.com> <56C1762E.9040208@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <56C1762E.9040208@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 15 Feb 2016, Krzysztof Kozlowski wrote: > On 12.02.2016 13:30, Javier Martinez Canillas wrote: > > The driver's init and exit function don't do anything besides adding and > > deleting the I2C driver so the module_i2c_driver() macro could be used. > > > > Currently is not being used because the driver is initialized at subsys > > initcall level, claiming that this is done to allow consumers devices to > > use the resources provided by this driver. But dependencies should be in > > the DT and consumers drivers should not rely in the registration order. > > > > Signed-off-by: Javier Martinez Canillas > > --- > > > > drivers/mfd/max77686.c | 13 +------------ > > 1 file changed, 1 insertion(+), 12 deletions(-) > > > > In the past not all dependencies supported deferred probing so such > ordering was required. > > I don't like the "dependencies should be in DT" reason for the change... > because it is kind of wishful thinking. Yeah, the dependencies should be > in DT, but are they? > > Instead *please check it* and write: > "Dependencies are in DT so manual ordering of init calls is not > necessary any more". > > My fast tests of this patch shown that it works good... but some more > thorough tests should be done. See to all of this, collect the Acks you've received and re-submit please. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog