From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751913AbcBOPez (ORCPT ); Mon, 15 Feb 2016 10:34:55 -0500 Received: from mail-bl2on0053.outbound.protection.outlook.com ([65.55.169.53]:14400 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751494AbcBOPey (ORCPT ); Mon, 15 Feb 2016 10:34:54 -0500 Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=caviumnetworks.com; Date: Mon, 15 Feb 2016 16:34:39 +0100 From: Jan Glauber To: Mark Rutland CC: Will Deacon , , Subject: Re: [RFC PATCH 1/7] arm64/perf: Basic uncore counter support for Cavium ThunderX Message-ID: <20160215153439.GA2586@hardcore> References: <8bd93a25e069ed6428bc6c21fc53270962ccafcc.1455295032.git.jglauber@cavium.com> <20160212173658.GD20262@leverpostej> <20160215140720.GA4053@hardcore> <20160215142726.GD9732@leverpostej> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160215142726.GD9732@leverpostej> User-Agent: Mutt/1.5.21 (2010-09-15) X-Originating-IP: [88.66.101.161] X-ClientProxiedBy: AM3PR07CA0022.eurprd07.prod.outlook.com (10.141.45.150) To DM2PR0701MB763.namprd07.prod.outlook.com (10.242.126.20) X-Microsoft-Exchange-Diagnostics: 1;DM2PR0701MB763;2:NMjlArgVAwQYEsR7/Tx9b84SQo8h7lCWVNEf2qL+0g+IDlx6qWPAI7HM5uNW6Zf1v6qlavpPcqniIT40KarjgFsBmA6PlMwDXnW30wOQyZXo7o/9923yJtXzXWZ13wjlUYjiGsDqu5Bxm05L30bTzQ==;3:k9xFsygfOD5NCF0mpYBSJj+5pkf7d30EW8v03DHwCDutLvWgmukA5gBBC6mOYuHo+ywbzrIKLhY0qc/9PAZhKga7EHu43SXwvs3BFeNEfGC61b5vOow6RGR39DnPSTHF;25:+FwfUDSSQ/vcoMGl56vLQ7Q8T8zOrkjZXK/jStsihxiROC5c8HAzndNX7lh3ca5+VUc42id0BSzEbeNAqZLWDB/K6tOiy3dX/Mh+ifP78/+vD/Q3HP1bV34N2cyPdO9AZj8i5ezn1xoeE03LyE2y46Do2njIR1TlFwGMSStWpyyDJGmxKqoj3vKh8ySiwJk9WEKQIgZDGPWn19GnHdMVMfY/adPmmiZfn+qUe1eZFebM12yXrUlFb6UW5SEyAWxCbJAuLvicMXGVQbHwRCjQe81F+1VchlfT7TgzunVijkfb24c/MkpddKciM5ErSuL3 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM2PR0701MB763; X-MS-Office365-Filtering-Correlation-Id: 7fc0f883-745f-490c-63eb-08d3361d8c76 X-Microsoft-Exchange-Diagnostics: 1;DM2PR0701MB763;20:O6FGA1TXrZu4Wz1w+mGOmzIctQFwsapiIk0iymPIuBG3pefT9SZBhnwS1bd667XJsXcqLRF0X082WNQMz9cGBMLBY5bcE1vcDaRvRneMINuHXJRXN0D+Kh/oXuLCgyeVDxMtg5DzxJtZ/VDbO8D3Lkn6ehhGaBQFLY8+SU7powOSwV9vSlbS1NpnCZ0vLU6US2FMIXSk5qaEqonVHc4YpbhSQV78iiyFxBvsK5NDN+m9w2g6U4GKfi8gRMyFvNtIOyuUNVyU+wcHegjeC0vyAHIBUm4I5JTZ8ev2Qn80PFHa+1/lPUPWfhR6gu2WEBehHmHWztpWjf1NryL2fLab3tekKvdXpPMMpRaOmRE8Gtl6zWFXHDecVyqw/RfF04LTKX5ItlF71CawF1CdV206gpDmkKDk8F0YirTzynS/9MylkPChfmFsUMbeeuUii/+ySOZIDBXuKti81ekOULeaqGm1RmlqjS8h8TQAe5YVToX2xql2iY0mv86LGYa/VoNl1i7MAbz525mtchlABIGwGzkk5vRlsN0Xj9QjWB6saNwuHt60cbXN9HPitKdOf0BaxL4dXxGJGT2ozLWTgDkp39wBcNdqA+MKb6i3cm7FO/o= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:DM2PR0701MB763;BCL:0;PCL:0;RULEID:;SRVR:DM2PR0701MB763; X-Microsoft-Exchange-Diagnostics: 1;DM2PR0701MB763;4:ibE75aVcPoZtY9T6lb4BNo1LYbI+U6VJtfyA6SnYJjlQNoTcKPUjafNveViXJf0rjk4DgWZ+ShR8Tux6BwfP9gZftQgSugJlL5yuzOHYN6zY7PYEN/b9x6VF0svlyZFtx/9BCxWRpeCCPYZ8+LmJBXapxBsgYl6J9ESFdHxROtf9mgMH0bcS1i87qdaUwKRLsceq4srSZefnSNIlJ0bLIldyp7QCuyj+9hP1d6/pcrgyjNDLkKt6faAkrNOgl1N/2DccsW5GAaDiY7myatufBnamMyXDubEY3IT/s6/MxbU1zzhOeCWVVF9nByp8G56VzXnUrJnynRXkqk7Id/A8OQRu5nqF89mnVVF/0DCTSAm2OgQqJhOiC9S0F/AaZEdW X-Forefront-PRVS: 08534B37A7 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(24454002)(77096005)(66066001)(46406003)(40100003)(1096002)(1076002)(122386002)(33656002)(23726003)(50466002)(586003)(92566002)(3846002)(6116002)(42186005)(5004730100002)(97756001)(189998001)(5008740100001)(2906002)(87976001)(54356999)(93886004)(76176999)(110136002)(50986999)(86362001)(33716001)(4001350100001)(5001960100002)(4326007)(83506001)(217873001);DIR:OUT;SFP:1101;SCL:1;SRVR:DM2PR0701MB763;H:hardcore;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DM2PR0701MB763;23:1BdB3jMLb9KitIuhj/vKEOFdEQl2aCNx2Nw8N3DG?= =?us-ascii?Q?WejCW4zh+QLo2wKynkxt/ItWtYQc1RF4oEOBz50gtNLPbF7dHgRrTAF8faZX?= =?us-ascii?Q?UbRy8kOTztXL3kbjjC7Zy25NDyCsjZeEMSFafyzXLJ1ClQR4SQSJDUaLbBPD?= =?us-ascii?Q?ipaDCBh9HLBBHj3uRArLHe0ktGKGHaqUm8JzionYoYYzJq2jumTQF3+7yUqK?= =?us-ascii?Q?K+HZbTp134ydf8rLK4NR1ZBIzpEp88AAQHiIkX2r5JMQRlAdZbFap6iYcsiA?= =?us-ascii?Q?LiSDECMgAo1PjNWtTq+mDe1c+a0yRxVhePBxZM3iYHjmuRoITs4z/6NGfKt6?= =?us-ascii?Q?lUtuLc5B1XWOnFJWTuZ9RHMwSeze6VbstxMYw/YpRcu9pFXlB8VCD0kA4EOU?= =?us-ascii?Q?cHryxlaLpW7eQG0Hu1XawdJgPTS6Bto0thFpAYgip40jhlUSKIinYyugMFiW?= =?us-ascii?Q?KlYd31LhFEyBvOktWjzILmLyCCZunrgYvUMSOQcjMZa7USz5DjnrDkLykXDy?= =?us-ascii?Q?i5zBhyrKhoKoT6dN9u8GRyTHsFTIyzWlBvp0oobmyC7QfVueAWFkfjFVFRMv?= =?us-ascii?Q?wQ9qATJm0idd/TZ1yQqpI0MznFu9jMj860LGsuoMJ6peDwvJfxt+4yWxDRUd?= =?us-ascii?Q?tcNUl+ED7cts0ZqwXcayrlDcCpSaKrikvzD1g61/Of0i3ZMxihSFRREXltPT?= =?us-ascii?Q?ycfMa/HgkY2UuBxi1HIeQQfSuvTvqwqD3V052B/SGzf8dU5tF0cYKgXjznuZ?= =?us-ascii?Q?yT4h4bnzhbpOsIST6KIT5u6HL863s6H90rAZAHdfuQJt9NqBxdRbiXaWjkXy?= =?us-ascii?Q?Na8whLbp/q+Noyl7vGg4msFmlyoVIy22Qyc6l169tXyHaGmn/DQhpKchlrcg?= =?us-ascii?Q?p0JrOHR7n6L/3x7jpyB4iynRPjhXdGz9uvvdHftVsjgm8m/TRrpJTj+K2p6S?= =?us-ascii?Q?GPwlUWetNsw9MqGVxRW5G2W+UhDKesbKFxjai7lw9A=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM2PR0701MB763;5:tPQBu3+xQNyTtGrHaN0RfidjI8y+zbOFI7osKKYZW17IjiGFEMl3w2DaKd4T0mTMs5gI0aPSK+VHHa1s9RD5Vj9sfBWu9dQ4bIYrn65Thxf5YZO85GU13wihLk0Q6FD9CkdmSAYZ0HG0vghOHL30cQ==;24:Qfe/pIzRXf/c4c39zn2MA391WxtrmxgYlctM+HIajOevcI+dFB9eHHpgjWUrKhksKaQ4WW2jVYxSsCEDROaDw2Tw/oUrf7/gVpQoIZtv06g= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2016 15:34:51.7736 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR0701MB763 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 15, 2016 at 02:27:27PM +0000, Mark Rutland wrote: > > > > 1) The PMU detection solely relies on PCI device detection. If a > > > > matching PCI device is found the PMU is created. The code can deal > > > > with multiple units of the same type, e.g. more than one memory > > > > controller. > > > > > > I see below that the driver has an initcall that runs regardless of > > > whether the PCI device exists, and looks at the MIDR. That's clearly not > > > string PCI device detection. > > > > > > Why is this not a true PCI driver that only gets probed if the PCI > > > device exists? > > > > It is not a PCI driver because there are already drivers like edac that > > will access these PCI devices. The uncore driver only accesses the > > performance counters, which are not used by the other drivers. > > Several drivers are accessing the same device? > > That sounds somewhat scary. I've double checked that the edac drivers do not access the performance counters at all. It felt cleaner to me to keep the performance counter code seperated from edac. Jan