From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753866AbcBORqY (ORCPT ); Mon, 15 Feb 2016 12:46:24 -0500 Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.226]:24011 "EHLO cdptpa-oedge-vip.email.rr.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751529AbcBORqW (ORCPT ); Mon, 15 Feb 2016 12:46:22 -0500 Date: Mon, 15 Feb 2016 12:46:06 -0500 From: Steven Rostedt To: Arnd Bergmann Cc: Michal Marek , linux-arm-kernel@lists.infradead.org, Peter Oberparleiter , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/5] Kbuild: disable 'maybe-uninitialized' warning for CONFIG_PROFILE_ALL_BRANCHES Message-ID: <20160215174606.GA11406@home.goodmis.org> References: <1455293187-179811-1-git-send-email-arnd@arndb.de> <1455293187-179811-3-git-send-email-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1455293187-179811-3-git-send-email-arnd@arndb.de> User-Agent: Mutt/1.5.24 (2015-08-30) X-RR-Connecting-IP: 107.14.168.130:25 X-Cloudmark-Score: 0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 12, 2016 at 05:06:19PM +0100, Arnd Bergmann wrote: > CONFIG_PROFILE_ALL_BRANCHES confuses gcc-5.x to the degree that it prints > incorrect warnings about a lot of variables that it thinks can be used > uninitialized, e.g.: > > i2c/busses/i2c-diolan-u2c.c: In function 'diolan_usb_xfer': > i2c/busses/i2c-diolan-u2c.c:391:16: warning: 'byte' may be used uninitialized in this function > iio/gyro/itg3200_core.c: In function 'itg3200_probe': > iio/gyro/itg3200_core.c:213:6: warning: 'val' may be used uninitialized in this function > leds/leds-lp55xx-common.c: In function 'lp55xx_update_bits': > leds/leds-lp55xx-common.c:350:6: warning: 'tmp' may be used uninitialized in this function > misc/bmp085.c: In function 'show_pressure': > misc/bmp085.c:363:10: warning: 'pressure' may be used uninitialized in this function > power/ds2782_battery.c: In function 'ds2786_get_capacity': > power/ds2782_battery.c:214:17: warning: 'raw' may be used uninitialized in this function > > These are all false positives that either rob someone's time when trying > to figure out whether they are real, or they get people to send wrong > patches to shut up the warnings. > > Nobody normally wants to run a CONFIG_PROFILE_ALL_BRANCHES kernel in > production, so disabling the whole class of warnings for this configuration > has no serious downsides either. > > Signed-off-by: Arnd Bergmann Acked-by: Steven Rostedt -- Steve > --- > Makefile | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index 9092c16fa6cf..352f55ccc54e 100644 > --- a/Makefile > +++ b/Makefile > @@ -617,7 +617,11 @@ KBUILD_CFLAGS += $(call cc-option,-fno-delete-null-pointer-checks,) > ifdef CONFIG_CC_OPTIMIZE_FOR_SIZE > KBUILD_CFLAGS += -Os $(call cc-disable-warning,maybe-uninitialized,) > else > -KBUILD_CFLAGS += -O2 > +ifdef CONFIG_PROFILE_ALL_BRANCHES > +KBUILD_CFLAGS += -O2 $(call cc-disable-warning,maybe-uninitialized,) > +else > +KBUILD_CFLAGS += -O2 > +endif > endif > > # Tell gcc to never replace conditional load with a non-conditional one > -- > 2.7.0