From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752642AbcBOS50 (ORCPT ); Mon, 15 Feb 2016 13:57:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35848 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751193AbcBOS5Z (ORCPT ); Mon, 15 Feb 2016 13:57:25 -0500 Date: Mon, 15 Feb 2016 13:57:23 -0500 From: Brian Foster To: Colin King Cc: Dave Chinner , xfs@oss.sgi.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] xfs: fix format specifier , should be %llx and not %llu Message-ID: <20160215185723.GE33291@bfoster.bfoster> References: <1455395182-4771-1-git-send-email-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1455395182-4771-1-git-send-email-colin.king@canonical.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Feb 13, 2016 at 08:26:22PM +0000, Colin King wrote: > From: Colin Ian King > > busyp->bno is printed with a %llu format specifier when the > intention is to print a hexadecimal value. Trivial fix to > use %llx instead. Found with smatch static analysis: > > fs/xfs/xfs_discard.c:229 xfs_discard_extents() warn: '0x' > prefix is confusing together with '%llu' specifier > > Signed-off-by: Colin Ian King > --- Reviewed-by: Brian Foster > fs/xfs/xfs_discard.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/xfs/xfs_discard.c b/fs/xfs/xfs_discard.c > index e85a951..272c3f8 100644 > --- a/fs/xfs/xfs_discard.c > +++ b/fs/xfs/xfs_discard.c > @@ -227,7 +227,7 @@ xfs_discard_extents( > GFP_NOFS, 0); > if (error && error != -EOPNOTSUPP) { > xfs_info(mp, > - "discard failed for extent [0x%llu,%u], error %d", > + "discard failed for extent [0x%llx,%u], error %d", > (unsigned long long)busyp->bno, > busyp->length, > error); > -- > 2.7.0 > > _______________________________________________ > xfs mailing list > xfs@oss.sgi.com > http://oss.sgi.com/mailman/listinfo/xfs