* [PATCH] irqchip/ts4800: Make ts4800_ic_ops static const
@ 2016-02-14 13:50 Axel Lin
2016-02-15 19:23 ` Damien Riegel
2016-02-18 2:12 ` Jason Cooper
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2016-02-14 13:50 UTC (permalink / raw)
To: linux-kernel; +Cc: Thomas Gleixner, Jason Cooper, Marc Zyngier, Damien Riegel
ts4800_ic_ops is only referenced in this driver, so make it static.
In additional, it's never get modified thus also make it const.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/irqchip/irq-ts4800.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/irqchip/irq-ts4800.c b/drivers/irqchip/irq-ts4800.c
index 4192bdc..2325fb3 100644
--- a/drivers/irqchip/irq-ts4800.c
+++ b/drivers/irqchip/irq-ts4800.c
@@ -59,7 +59,7 @@ static int ts4800_irqdomain_map(struct irq_domain *d, unsigned int irq,
return 0;
}
-struct irq_domain_ops ts4800_ic_ops = {
+static const struct irq_domain_ops ts4800_ic_ops = {
.map = ts4800_irqdomain_map,
.xlate = irq_domain_xlate_onecell,
};
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] irqchip/ts4800: Make ts4800_ic_ops static const
2016-02-14 13:50 [PATCH] irqchip/ts4800: Make ts4800_ic_ops static const Axel Lin
@ 2016-02-15 19:23 ` Damien Riegel
2016-02-18 2:12 ` Jason Cooper
1 sibling, 0 replies; 3+ messages in thread
From: Damien Riegel @ 2016-02-15 19:23 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Thomas Gleixner, Jason Cooper, Marc Zyngier
On Sun, Feb 14, 2016 at 09:50:04PM +0800, Axel Lin wrote:
> ts4800_ic_ops is only referenced in this driver, so make it static.
> In additional, it's never get modified thus also make it const.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Reviewed-by: Damien Riegel <damien.riegel@savoirfairelinux.com>
Thanks for catching this.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] irqchip/ts4800: Make ts4800_ic_ops static const
2016-02-14 13:50 [PATCH] irqchip/ts4800: Make ts4800_ic_ops static const Axel Lin
2016-02-15 19:23 ` Damien Riegel
@ 2016-02-18 2:12 ` Jason Cooper
1 sibling, 0 replies; 3+ messages in thread
From: Jason Cooper @ 2016-02-18 2:12 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel, Thomas Gleixner, Marc Zyngier, Damien Riegel
On Sun, Feb 14, 2016 at 09:50:04PM +0800, Axel Lin wrote:
> ts4800_ic_ops is only referenced in this driver, so make it static.
> In additional, it's never get modified thus also make it const.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/irqchip/irq-ts4800.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to irqchip/core with Damien's Reviewed-by.
thx,
Jason.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-18 2:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-14 13:50 [PATCH] irqchip/ts4800: Make ts4800_ic_ops static const Axel Lin
2016-02-15 19:23 ` Damien Riegel
2016-02-18 2:12 ` Jason Cooper
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).