From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933648AbcBQBgL (ORCPT ); Tue, 16 Feb 2016 20:36:11 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:42650 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933611AbcBQBgJ (ORCPT ); Tue, 16 Feb 2016 20:36:09 -0500 Date: Tue, 16 Feb 2016 20:36:06 -0500 (EST) Message-Id: <20160216.203606.1431228679408727525.davem@davemloft.net> To: sudipm.mukherjee@gmail.com Cc: f.fainelli@gmail.com, linux-kernel@vger.kernel.org, kernel-testers@vger.kernel.org, netdev@vger.kernel.org, geert@linux-m68k.org, helmut.buchsbaum@gmail.com Subject: Re: [PATCH v2] net: phy: spi_ks8995: add dependency on GPIO From: David Miller In-Reply-To: <1455372195-10825-1-git-send-email-sudipm.mukherjee@gmail.com> References: <1455372195-10825-1-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 16 Feb 2016 17:36:09 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sudip Mukherjee Date: Sat, 13 Feb 2016 19:33:15 +0530 > The builds of allmodconfig of s390, m68k, tilegx, tilepro is failing > with the error: > drivers/net/phy/spi_ks8995.c:477:3: error: implicit declaration of function 'gpiod_set_value' > drivers/net/phy/spi_ks8995.c:477:19: error: implicit declaration of function 'gpio_to_desc' > > GPIO is now used to reset the switch so we should have a dependency on > GPIOLIB. While adding the dependency also add COMPILE_TEST so that we > can build test it. > > Fixes: cd6f288cbaab ("net: phy: spi_ks8995: add support for resetting switch using GPIO") > Cc: Helmut Buchsbaum > Signed-off-by: Sudip Mukherjee > --- > > v2: added COMPILE_TEST and gpio/consumer.h I'm going to apply Arnd's patch because it properly removes the unnecessary linux/gpio.h include. Thanks.