* [PATCH] staging: wilc1000: remove wilc1000_spi_ops as it is not used
@ 2016-02-15 15:18 Colin King
2016-02-16 2:22 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2016-02-15 15:18 UTC (permalink / raw)
To: Johnny Kim, Austin Shin, Chris Park, Tony Cho, Glen Lee, Leo Kim,
Greg Kroah-Hartman, linux-wireless, devel
Cc: linux-kernel
From: Colin Ian King <colin.king@canonical.com>
building with gcc 6 I hit a build failure:
CC drivers/staging/wilc1000/wilc_spi.o
drivers/staging/wilc1000/wilc_spi.c:123:34: error: storage size of
‘wilc1000_spi_ops’ isn’t known
static const struct wilc1000_ops wilc1000_spi_ops;
^~~~~~~~~~~~~~~~
drivers/staging/wilc1000/wilc_spi.c:123:34: warning: ‘wilc1000_spi_ops’
defined but not used [-Wunused-const-variable]
Since wilc1000_spi_ops is not used, remove it and the driver builds.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/staging/wilc1000/wilc_spi.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/wilc1000/wilc_spi.c b/drivers/staging/wilc1000/wilc_spi.c
index 86de50c..b3d6541 100644
--- a/drivers/staging/wilc1000/wilc_spi.c
+++ b/drivers/staging/wilc1000/wilc_spi.c
@@ -120,8 +120,6 @@ static u8 crc7(u8 crc, const u8 *buffer, u32 len)
#define USE_SPI_DMA 0
-static const struct wilc1000_ops wilc1000_spi_ops;
-
static int wilc_bus_probe(struct spi_device *spi)
{
int ret, gpio;
--
2.7.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: wilc1000: remove wilc1000_spi_ops as it is not used
2016-02-15 15:18 [PATCH] staging: wilc1000: remove wilc1000_spi_ops as it is not used Colin King
@ 2016-02-16 2:22 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2016-02-16 2:22 UTC (permalink / raw)
To: Colin King
Cc: Johnny Kim, Austin Shin, Chris Park, Tony Cho, Glen Lee, Leo Kim,
linux-wireless, devel, linux-kernel
On Mon, Feb 15, 2016 at 03:18:27PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> building with gcc 6 I hit a build failure:
>
> CC drivers/staging/wilc1000/wilc_spi.o
> drivers/staging/wilc1000/wilc_spi.c:123:34: error: storage size of
> ‘wilc1000_spi_ops’ isn’t known
> static const struct wilc1000_ops wilc1000_spi_ops;
> ^~~~~~~~~~~~~~~~
> drivers/staging/wilc1000/wilc_spi.c:123:34: warning: ‘wilc1000_spi_ops’
> defined but not used [-Wunused-const-variable]
>
> Since wilc1000_spi_ops is not used, remove it and the driver builds.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/staging/wilc1000/wilc_spi.c | 2 --
> 1 file changed, 2 deletions(-)
Doesn't apply to my tree at all, are you sure you are using linux-next
for this?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-16 2:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-15 15:18 [PATCH] staging: wilc1000: remove wilc1000_spi_ops as it is not used Colin King
2016-02-16 2:22 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox