From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754286AbcBPIPG (ORCPT ); Tue, 16 Feb 2016 03:15:06 -0500 Received: from mail-bn1bon0099.outbound.protection.outlook.com ([157.56.111.99]:3102 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754257AbcBPIPD (ORCPT ); Tue, 16 Feb 2016 03:15:03 -0500 X-Greylist: delayed 870 seconds by postgrey-1.27 at vger.kernel.org; Tue, 16 Feb 2016 03:15:03 EST Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=caviumnetworks.com; Date: Tue, 16 Feb 2016 09:00:15 +0100 From: Jan Glauber To: Will Deacon CC: Mark Rutland , , Subject: Re: [PATCH v3 5/5] arm64/perf: Extend event mask for ARMv8.1 Message-ID: <20160216080015.GA3490@hardcore> References: <20160215200404.GX6298@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160215200404.GX6298@arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Originating-IP: [46.223.157.133] X-ClientProxiedBy: DB4PR03CA0022.eurprd03.prod.outlook.com (25.160.39.160) To SN2PR0701MB766.namprd07.prod.outlook.com (25.160.15.144) X-Microsoft-Exchange-Diagnostics: 1;SN2PR0701MB766;2:T5GCcAW51iisjOpWXFU4yub80ccbY38WlKKm4sSQ5lQyw/S22Xam6wDjV2Zk+8bDTdaEnuq1w8ZzsqfMlcgdYgS9LFfVBtyKfCDr9xq0Bx/RJf8WCzETHA1ywxY11kH0pOtMWPtBghC3GBdT4SI7fA==;3:hLfBuWn+ghBZsnfhHy/+deLc09WNYQEW4mdUILTHs94VzNazMTRyz5qn2+6/JGw/f/Uf4lId9b2bOXVNoHU05ft5PoWXPJXxh3i+IeMaKjOSdJtvD78VCaYeAzcgI8w7;25:SnvpcB2UXMU13KumPWSG9yFAMG98rnwvmh6fOXCnX3/Q5t1eE1KLlq61gBjK8DXV/i29AJA35m04bFo49zEAGhWK2XobGwCbg3t3s4VRs7M1Kh34TSCVK9eF6bLm+DJ9QyRlSPzWFsxuiQiLIBMTWUV1rElHc09UFqngWH6gVWqHHIQWhuTDEipxQsIM9GSQ63Qnp5S2dNu6ZOCW3ukDeVzWUIKSMSe3wVihqIM7U4RwzYWcYhl7FvymekOo44TnrCrwOwP5miM09aD08Y0pBqUxSscmh6W1KRNrM/MHs3wcIP7e+Ff5Bmz1QKLWtla4 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN2PR0701MB766; X-MS-Office365-Filtering-Correlation-Id: b849d576-0424-4845-3e2c-08d336a73d9d X-Microsoft-Exchange-Diagnostics: 1;SN2PR0701MB766;20:Ej1hN/Mwoml0GuJTLcZcOxPb4n8X9TyaphIFZTzb1RbzZUHWhm7LYSQeo9G9XgxKXNa6RJXDtGnl/8XCZnTP+Pke1iHDk/A3j4WbzQekcQqlLOtQpGvQmo0EFnqyy4OQRWwFdpGmMMiNElIiEaFU80iXqRLSdwBnRXTsw19UHQHbaHzOT3f3KEaxVK3KvNcxdkeC227l4guM0XkVkxuYPNHkQTmybp/OkZ5CcZlKJdPgW/M8S0sAj9U75dEKRRdlUikiIAuplCH52rfkmSC1Nvz8uAUqBNX1J0LXGGZBCmJivSTQu25inAOdJv+lVylgSGpnmFEuFz6Ne8hVeJDP5Vo7HnGrpA8uiZ5sf7QokUNHxJwy915jdp36AfRGvcbWTYsutXtuRSBxZD4P8U/YCSYQBXbSuYUpBFRsBfubGhrHFgyIRVDp6+aSYbuRBwdaXOOhGBLcZQea7Jo4cXCwIKpv0pBd1AP3srRymNSiBJ0xWQX4vp9YJHejFtfeOdmJkUyY16BpsuxSnRFCFWNTZCbqPpTtCrLscMRKHKDUQdq1xFdjdOn2vnEXEwD5oZVOskITQCVdkc8lQELeDQG6442Fka0/P7Y/UuZpNfvJIrc= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046);SRVR:SN2PR0701MB766;BCL:0;PCL:0;RULEID:;SRVR:SN2PR0701MB766; X-Microsoft-Exchange-Diagnostics: 1;SN2PR0701MB766;4:Joj2AL2D80umuWvUzr75yB+1Tqwxv1fzSPv+C/gIcgPDG4GhCxgMMbh/m9zQPMgV0OY/NL9uaC3QCBSl7EeKf0aJ21dC5D92vjLmrjiECaoCwYT44DPvj4oL4ldJGR1Pbd7RgXN7Q/CAUQPjnMiFXCqHlnDSZKWf7VMv4QHnyX9kqZvjAZNbRDpgfnCMTVXriAyPd5aXAD5TyyPAdZYavUPRk5jWFDQQx7XF6vVGhhIssXRBA/cVv/hWAmMU4kbglZoOkUX96z2SuUpyZko8wUf4Mx+S1UG7q3tpZLM2npT2T7VQYHEjBorS7d0zv7WOCX9Ck1s6k3ngL7M3DL/Vnl+0wDDbnRzcQmT21J2LPQ1SFl+aVp7HmTW5Td78W9nd X-Forefront-PRVS: 0854128AF0 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(24454002)(1096002)(1076002)(110136002)(50986999)(5001960100002)(586003)(54356999)(76176999)(189998001)(3846002)(23726003)(87976001)(6116002)(40100003)(33656002)(66066001)(83506001)(122386002)(33716001)(5004730100002)(4001350100001)(5008740100001)(2950100001)(97756001)(86362001)(50466002)(42186005)(4326007)(92566002)(47776003)(77096005)(2906002)(46406003);DIR:OUT;SFP:1101;SCL:1;SRVR:SN2PR0701MB766;H:hardcore;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;SN2PR0701MB766;23:aEfc13j8AE7bQV4M56+lC4/ecVE2Vlg/zePkw+9U?= =?us-ascii?Q?aEUp3r0UD/mRqOlI83XsNj3jasMukOHrK6boNlByZVWDVDN/RysxcBXV0Kb2?= =?us-ascii?Q?AWek/tH5h5Y78WvaY/Znfp5Kt85bCYrSTfAkRTKId6rIjuOjc8GM4u1818sw?= =?us-ascii?Q?sw7mNXOwJR/IcDmuXr76pG6bhxTtthbGqy2UEV+Si+hOU7LMZcbI24wuaAmm?= =?us-ascii?Q?usBWykFolLEa9jl1iW4ZBwpfmRVYgOiO2kXO2eHGsdvV2PfyY4enxkY3UZ/5?= =?us-ascii?Q?huUvEWYC4mrFuzA2Xhk9ZYFYsS0FKAMzO5iQYkAz+PzVHGaVmZO13ocFbMHT?= =?us-ascii?Q?VoABZMugrbTPfJqCdjlWxU7CJJPJB5AWuOLKw4J2JZVmCXwwg0kdl+TJaSVN?= =?us-ascii?Q?KpvVpvl9XN8151Fo5brNGhazTmRWQ4gtpXtmf+wU1C4gBFemTcRkpP8oLSLv?= =?us-ascii?Q?jR5mPs/NzYbXhdyefktwg8UElMsprrgE6Ugmi+RaRcIWzhXefMfbWQRCHcRt?= =?us-ascii?Q?sbhdVoGBx8nyAQDVGQGo//F20PgP0NsfDw+/9PcC/WSqgxycpWLBt80vB96J?= =?us-ascii?Q?BEjUkMjEruRSd231MP0VimoAX7J4rwz5MJBIXeKGQeKynelnv+lgRy+XJjGl?= =?us-ascii?Q?ZkBNlzmfrTEv3iSoUkm0BF7OLx3EnpZf2X5ClBzXt5tuW4UGV9Ijso6JMTC2?= =?us-ascii?Q?Aj5WLkFkhOUW4zmJ1zzp9T5cPMOJq4jZ999/EsueXk3Z5aii07yNMbdWNHkv?= =?us-ascii?Q?/7/3vejGHZSSCtquzxnHZ8pFBSIXCAxSxdB0wpuAS9E2vBZuzSlOL40hd11G?= =?us-ascii?Q?yR1mQAjJxdRqTqJunRbHcWZowCxkyzG24A8uRIEb9KfBu38kLcq0wU16oUnm?= =?us-ascii?Q?rLsJQIQO5MxfFiT8ulkyD7VIk77TLxiyCIcv+o1ZwHl8j4BhXwCvjY1qZaQA?= =?us-ascii?Q?CvMGCnEUr3amj44LQ/faIQbLps7DsMvNH/VxriyclA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;SN2PR0701MB766;5:CAfsrvupMIjLJDMDne5ZWthw3Hcw7Ls3TSyP7pSC++etfF8UMk9tocbdMKuyL11itFrn438oGIMa4QtgNrWfVDhfrxvVNOIWNpn42swGFnovtlkAiDRnHFX1idofKbPF9HtWcTEMEjIonR7XRKVAbg==;24:od9utSS8x1wSHli8En1pxqqcX3ruGJCzpLB+QWZf5ChE+AZFfr9jaCFnhD1AX8HcTpuE9I9J3y6dJFkFW5ZWrBRtO/wykmzYAp42pA0TkgU= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2016 08:00:29.8806 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR0701MB766 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 15, 2016 at 08:04:04PM +0000, Will Deacon wrote: [...] > On Wed, Feb 03, 2016 at 06:12:00PM +0100, Jan Glauber wrote: > > + cpu_pmu->event_mask = 0xffff; /* ARMv8.1 extended events */ > > + else > > + cpu_pmu->event_mask = ARMV8_EVTYPE_EVENT; > > ... although can't we just update ARMV8_EVTYPE_EVENT to be 0xffff now? > AFAICT, that just eats into bits that used to be RES0, so we shouldn't > see any problems. That should make your patch *much* simpler! That would of course be easier, but I just can't assess the implications. Probably I'm missing something but to me it looks like the event mask is the only verification we do for the user-space selectable events. Is it safe for implementations that only support 0x3ff events to allow access to the whole 0xffff range? What memory would be accessed for non-existing events? Jan > Will