From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754207AbcBPITe (ORCPT ); Tue, 16 Feb 2016 03:19:34 -0500 Received: from mail-bn1bon0073.outbound.protection.outlook.com ([157.56.111.73]:19840 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751478AbcBPITc (ORCPT ); Tue, 16 Feb 2016 03:19:32 -0500 Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=caviumnetworks.com; Date: Tue, 16 Feb 2016 09:04:24 +0100 From: Jan Glauber To: Will Deacon CC: Mark Rutland , , Subject: Re: [PATCH v3 4/5] arm64/perf: Enable PMCR long cycle counter bit Message-ID: <20160216080424.GB3490@hardcore> References: <20160215195529.GW6298@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160215195529.GW6298@arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Originating-IP: [46.223.157.133] X-ClientProxiedBy: DB4PR08CA0021.eurprd08.prod.outlook.com (25.161.12.31) To CO2PR0701MB759.namprd07.prod.outlook.com (10.141.245.21) X-Microsoft-Exchange-Diagnostics: 1;CO2PR0701MB759;2:krVOom7bATlxZnhIIe0gvf8dZ04b8+EO4UgotLPq/A9VFxrdl1L9cpGJEPlk0GyKPproTljBtQze0vwyxjYsEY0ze1380NLwtPEY/JYGF+cBEn3i1f4TjnCTAUpdvA3TyvYqrqjsWwDMmsgwZMYnhw==;3:Qme7pxJnPaqdIku7Kxnk9TrJX24mgfGGd8ewTN3sjOW1fIeJHzBikL9HC9UWOf+W4whOVK0QZMI7wKL3QnyBgTRBQIY0O9R/RYgi2XEQatFZq8F/NH9JgjSosIkUyGEm;25:HIiUnNNRspgEpJ4HywoMeQteJHcHT8PGGaqt2UKhgaOkeCnigx67Qm+o3jSlGggeMRvlPopFp5gJ9lFgugqhAPvKj10pKP3V0uIiLRn9J2+/ejg122OI6ZL0dTQ/VLB8E0FAVYs7I325ZMUt0s587WhacT9ytDIcHc+Sl24ybQ3C77u/aldN6p1xiTvmbMOGIf+fS7nB5M6MB5uMCmvRodnjgXHFWZrMP9KmDehizhp51Ao86D0EVZWih0VftBw3zKziMq6aeFP5bFxjal4mJOYebnMXFSqFwjRwIQUgwW8cdvF6S22jsEPXxlGhits0 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CO2PR0701MB759; X-MS-Office365-Filtering-Correlation-Id: 7ea41712-5c8e-4848-bcb1-08d336a7d2ab X-Microsoft-Exchange-Diagnostics: 1;CO2PR0701MB759;20:ne3F4vH0X7phPboryMOB/l6yDg5gpf3J5UzV393v2n5ConBCuDtM2N6bYDehmb4CP0Otzln+XHZU89ytb4Hpazj2BiVT8Ctdf+4YcAvVJob9Tg3HjI6iaV28ZJJq080SbqFzuE7+4ru3bZNuCYzawg6FgCd2icRvP0Jfe7y7btT6KUZ3q6xIvuJrqJ2J2bGcFShTFCwS7zs/yRqkcFUcluZC+RhnAbt68amdvlnytYv3t3nRvn/6cYKzztH8U2sqT4VAzJPgxUGN2yQwEHdVxy4IjwAnRzLbFUCIp3vlTokk0Kx5BEaafEnTM06vRYEIZC50dd+FXc9r6FSgMPUlu4THK3accseBYeEbI3Rer3L7txK0H4ju7tRyXCCHSRCbfDhJI9wxOLCIo6l04maVyU17aHHbQ2KwXOgsBqNPKyz2F+ZtLgjYofr+TRFTsTweGkiXY/pCiDvk1SPAo/ux4iQRASuczaJ9J2GKU5jie6UJR3goVnT4sOkK9p6BsyVe1pS/5IfTw7hycGsPy7wkKGjFF78/IHdnPoI1B5I5fDKQ+UACwo3G5ikNgTY53vNwsIO2OdBjl3pzn76mS9UNHub4i7hKW884IOplJLfW0ag= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001);SRVR:CO2PR0701MB759;BCL:0;PCL:0;RULEID:;SRVR:CO2PR0701MB759; X-Microsoft-Exchange-Diagnostics: 1;CO2PR0701MB759;4:5szweZRIh99hM7aUD2/reZm1+6gjKVqHj++ymMKvzyftHMhbqptMd3ky1AEqhPzKghKRbbOZ0YESqBYjH2frIRed2NQvuvViO4U7TB+MNEsjcktCCsv3wpWStCZ4wkQf3nhd1rbYXp3Z3V5oWo4KJTVC4DvTgsEiPaI8PsX35OF0tkQ3UM2mMaPHVMxvkrp3TvtJtSQtIxkVmkt4emsEGbnblvbt5yo75sxNIv+BqDeT8H/AZw4IeC42S5kkqiqhx5UcQryE+fxL+eahSdnOrA5O+iuRgRhE7oa1ttIu5SKLlS367az98l/VvJwP2Z/bfn3sry2Cm9O3SEheCpe+bL2qMLQF5ggU4G9YTIwSLuuQWMAjJYuXwFgwk2zYaaYz X-Forefront-PRVS: 0854128AF0 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(24454002)(92566002)(5001960100002)(189998001)(47776003)(76176999)(50986999)(2906002)(586003)(5004730100002)(4326007)(54356999)(87976001)(110136002)(4001350100001)(46406003)(66066001)(1076002)(1096002)(6116002)(5008740100001)(83506001)(23726003)(2950100001)(3846002)(33656002)(122386002)(33716001)(50466002)(97756001)(77096005)(86362001)(40100003)(42186005);DIR:OUT;SFP:1101;SCL:1;SRVR:CO2PR0701MB759;H:hardcore;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CO2PR0701MB759;23:ubIxAfQM7pYBWkomvmk70/va7oGhgOarJSrQQ/KA?= =?us-ascii?Q?cPqw4WztvV4KquudowXIhA1Maoyo53anbSLDsUfBbNRMhursJHsBwhsVcrJU?= =?us-ascii?Q?jXnEyGGX6lUnGym0ZPA0W9ynHFP6Gp4pwtCYl9WQQC8fjFCbmU9DL4foPtDM?= =?us-ascii?Q?bYKuD98vZnCO5hl6w30s/aqDpugB3cvf8N9dEZvRA9nfGS8Z34HjAgs6JF3H?= =?us-ascii?Q?neHke7hyoc7rstMCwOR9AdDxYijkNFu9wOsoOb6/b8pwxRMgYrTkYR8FYxz5?= =?us-ascii?Q?lQ2Gs6pi6Irrz90l/PjkWV7OsbNBNGXDRAp3LAGFWBAtu+CsvHJoiqH0zI0i?= =?us-ascii?Q?IMhXxP3ARuXoudCrWPJYcD/cuy0b6vv0FrkP1dn8pZNpFnotJbtkF+4rWTlb?= =?us-ascii?Q?LyIU5F+/dK76Hnh8SOqJ1q3UMXU4OFF+L2wfaa6YKVQseSKILAY5/MsLuZvU?= =?us-ascii?Q?J9Yc5yvd69R4Vaxh0sRiWjAGFK19IDqRNO1ioJ8IQF963Zsw4oZ2lw7xUfBt?= =?us-ascii?Q?iQj8CndIvsmmjfQw5XhdYpkY4APy4yuEdnyEW8Mrw1fo5C+drTYM5duZ/Sv0?= =?us-ascii?Q?MGL8GPismUFss6TRoHUnHqVIWIDzZsoL7+G9LOvIVW2aSUAinjN9k1IZuXuA?= =?us-ascii?Q?AYDAN3fL8RyKpHPlCfygJzQ8LB0bgzgjF3IzE5d4/4s+umI8eMPoTEGPLTr4?= =?us-ascii?Q?RDy3ftjflIP9LBPeya6me7Z88o0FtUkeojEpNGPERXpHEIwcst/qB2g7ASvR?= =?us-ascii?Q?/RAZUiJ6B+9Jo5FR9GOvj+GQuUCEf+Y1S/hVtMmFLLtJWwqnthS6xXLYt24r?= =?us-ascii?Q?/G1oeP/9U8Ksvb9bq4SWQPjjrIa35+VSMHKaQ+05rdHFVD38ulq1Nn3Xy2fX?= =?us-ascii?Q?ipY+oH6XPKW+obLN7T6a9XM80Fa1ANmVHgGEgh+5x9HmrOz4qzC2GuqCdZlZ?= =?us-ascii?Q?ih8g3TKpsYo6eNC6hjnI3TlGgAxcY7/14J6IM4GYrA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;CO2PR0701MB759;5:4zibkV+cTkdZ5uAAdHy/fsoaOqeU7KfJTpecG7gS/l0tbPwSx+iyj7hhRLuppadRdHE+tJgxh825WOBnqdiRhuhfFzCJSn2604+PzWZtjvsyeqe+KnDR5JtVgiTzyhn24iSr37SJM6AH4L7DQIPNNw==;24:2bzaWJ33kV52WSyRkphP4twFcZoY6FPyIMztXjhIzq/Qai/cJK/klNwWE+oyCPuFP2PdI7+FqtAJkX8mIQcz8Ls7CX5Wwu5GRhLMvayBp8Y= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2016 08:04:39.6749 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR0701MB759 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 15, 2016 at 07:55:29PM +0000, Will Deacon wrote: > On Wed, Feb 03, 2016 at 06:11:59PM +0100, Jan Glauber wrote: > > @@ -768,8 +776,11 @@ static void armv8pmu_reset(void *info) > > armv8pmu_disable_intens(idx); > > } > > > > - /* Initialize & Reset PMNC: C and P bits. */ > > - armv8pmu_pmcr_write(ARMV8_PMCR_P | ARMV8_PMCR_C); > > + /* > > + * Initialize & Reset PMNC. Request overflow on 64 bit but > > + * cheat in armv8pmu_write_counter(). > > Can you expand the comment to mention that the 64-bit overflow is only > for the cycle counter, please? OK, how about: /* * Initialize & Reset PMNC. Request overflow interrupt for * 64 bit cycle counter but cheat in armv8pmu_write_counter(). */ Jan > Will