From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754208AbcBPIYg (ORCPT <rfc822;w@1wt.eu>);
	Tue, 16 Feb 2016 03:24:36 -0500
Received: from mail-wm0-f52.google.com ([74.125.82.52]:33096 "EHLO
	mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751007AbcBPIYf (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 16 Feb 2016 03:24:35 -0500
Date: Tue, 16 Feb 2016 09:24:31 +0100
From: Ingo Molnar <mingo@kernel.org>
To: Borislav Petkov <bp@alien8.de>
Cc: Chen Yucong <slaoub@gmail.com>, tglx@linutronix.de, hpa@zytor.com,
        x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] x86/kernel: use pr_<level>() and dev_<level>
Message-ID: <20160216082431.GA3335@gmail.com>
References: <1455423047-8571-1-git-send-email-slaoub@gmail.com>
 <20160214140808.GB32622@pd.tnic>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160214140808.GB32622@pd.tnic>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Borislav Petkov <bp@alien8.de> wrote:

> > @@ -70,10 +70,10 @@ do {									\
> >  		if (!(len))						\
> >  			break;						\
> >  									\
> > -		printk(KERN_DEBUG fmt, ##args);				\
> > +		pr_debug(fmt, ##args);				\
> >  		for (j = 0; j < (len) - 1; j++)				\
> > -			printk(KERN_CONT "%02hhx ", buf[j]);		\
> > -		printk(KERN_CONT "%02hhx\n", buf[j]);			\
> > +			pr_cont("%02hhx ", buf[j]);		\
> > +		pr_cont("%02hhx\n", buf[j]);			\
> >  	}								\
> >  } while (0)
> >  
> 
> NAK the hell out of that hunk!
> 
> Did you actually look at how pr_debug() is defined?
> 
> Yeah, I don't think so. With your change, when I boot with
> "debug-alternative" I get:
> 
> ...
> [    0.064005] Last level dTLB entries: 4KB 512, 2MB 255, 4MB 127, 1GB 0
> [    0.068005] e9 d5 3e d3 00
> [    0.072004] e9 e8 92 21 ff
> [    0.075003] eb 11 0f 1f 00
> [    0.077906] e8 c5 b6 30 00
> [    0.084009] f3 48 0f b8 c7

Hm, so I suspect the other patch I already applied is buggy as well?

triton:~/tip> git log -1 -p 1b74dde7c47c | grep KERN_DEBUG
-                       printk(KERN_DEBUG "tseg: %010llx\n", tseg);
-                       printk(KERN_DEBUG "CPU%d: Thermal monitoring handled by SMI\n", cpu);
-#define Dprintk(x...) do { if (debug_print) printk(KERN_DEBUG x); } while (0)
-               printk(KERN_DEBUG "After WB checking\n");
-                       printk(KERN_DEBUG "MTRR MAP PFN: %016llx - %016llx\n",
-               printk(KERN_DEBUG "After UC checking\n");
-                       printk(KERN_DEBUG "MTRR MAP PFN: %016llx - %016llx\n",
-               printk(KERN_DEBUG "After sorting\n");
-                       printk(KERN_DEBUG "MTRR MAP PFN: %016llx - %016llx\n",
-               printk(KERN_DEBUG "reg %d, base: %ld%cB, range: %ld%cB, type %s\n",
-       printk(KERN_DEBUG "original variable MTRRs\n");
-                       printk(KERN_DEBUG "New variable MTRRs\n");
-               printk(KERN_DEBUG "New variable MTRRs\n");
-                       printk(KERN_DEBUG "Failed to setup IBS LVT offset, "
-               printk(KERN_DEBUG "No CPU node configured for IBS\n");
-               printk(KERN_DEBUG "No EILVT entry available\n");

Thanks,

	Ingo