From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754891AbcBPKPe (ORCPT ); Tue, 16 Feb 2016 05:15:34 -0500 Received: from pandora.arm.linux.org.uk ([78.32.30.218]:55234 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754453AbcBPKP3 (ORCPT ); Tue, 16 Feb 2016 05:15:29 -0500 Date: Tue, 16 Feb 2016 10:15:10 +0000 From: Russell King - ARM Linux To: Mathieu Poirier Cc: Paul Gortmaker , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH] drivers/hwtracing: make coresight-* explicitly non-modular Message-ID: <20160216101509.GB19428@n2100.arm.linux.org.uk> References: <1455470351-15219-1-git-send-email-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 15, 2016 at 06:25:56PM -0700, Mathieu Poirier wrote: > On 14 February 2016 at 10:19, Paul Gortmaker > wrote: > > diff --git a/include/linux/amba/bus.h b/include/linux/amba/bus.h > > index 9006c4e75cf7..3d8dcdd1aeae 100644 > > --- a/include/linux/amba/bus.h > > +++ b/include/linux/amba/bus.h > > @@ -163,4 +163,13 @@ struct amba_device name##_device = { \ > > #define module_amba_driver(__amba_drv) \ > > module_driver(__amba_drv, amba_driver_register, amba_driver_unregister) > > > > +/* > > + * builtin_amba_driver() - Helper macro for drivers that don't do anything > > + * special in driver initcall. This eliminates a lot of boilerplate. Each > > + * driver may only use this macro once, and calling it replaces the instance > > + * device_initcall(). > > + */ > > +#define builtin_amba_driver(__amba_drv) \ > > + builtin_driver(__amba_drv, amba_driver_register) > > + > > #endif > > -- > > 2.6.1 > > > > I'm good with this patch on the CS side but Russell maintains the amba > subsystem and as such needs to agree with the new macro. Russell, I > offer to take this through my tree if you're fine with the changes. Acked-by: Russell King -- RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.