From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752955AbcBPCmc (ORCPT ); Mon, 15 Feb 2016 21:42:32 -0500 Received: from mx0b-0016f401.pphosted.com ([67.231.156.173]:35551 "EHLO mx0b-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752503AbcBPCm3 (ORCPT ); Mon, 15 Feb 2016 21:42:29 -0500 Date: Tue, 16 Feb 2016 10:38:02 +0800 From: Jisheng Zhang To: Adrian Hunter , Ulf Hansson CC: Arnd Bergmann , Ludovic Desroches , Stephen Warren , "Lee Jones" , Eric Anholt , Michal Simek , =?UTF-8?B?U8O2cmVu?= Brinkmann , Srinivas Kandagatla , Maxime Coquelin , Patrice CHOTARD , Thierry Reding , Sebastian Hesselbarth , , linux-mmc , "linux-kernel@vger.kernel.org" , , "linux-tegra@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v4 00/13] mmc: use sdhci_pltfm_init for private allocation and clean up Message-ID: <20160216103802.266f356c@xhacker> In-Reply-To: <56B8A1A1.2080408@intel.com> References: <1453803353-6266-1-git-send-email-jszhang@marvell.com> <56B8A1A1.2080408@intel.com> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.29; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-02-16_02:,, signatures=0 X-Proofpoint-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=9 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1601100000 definitions=main-1602160047 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dear Adrian, Ulf, On Mon, 8 Feb 2016 16:09:37 +0200 Adrian Hunter wrote: > On 04/02/16 12:38, Ulf Hansson wrote: > > + Adrian > > > > On 26 January 2016 at 11:15, Jisheng Zhang wrote: > >> These patches are to complete the TODOs in Commit 0e748234293f ("mmc: > >> sdhci: Add size for caller in init+register"), I.E: > >> > >> - todo: migrate clients to using allocation this way > >> - todo: remove priv variable once migration is complete > >> > >> Since v3: > >> - based on v4.5-rc1 > >> - add Ludovic's ack for sdhci-of-at91 changes > >> - fix use-after-free in some drivers: some host drivers still needs to > >> access sdhci_pltfm_host->private after sdhci_pltfm_unregister(), but > >> the private should be already freed by sdhci_pltfm_unregister. > >> - add patch5 to fix one clk bug in sdhci_arasan_remove(). IMHO, It's > >> better to add this patch to fixes rather than waiting for next merge > >> window > >> > >> Since v2: > >> - based on mmc next tree and remove all priv usage introduced in newly > >> commits in this tree > >> - don't break two lines if sdhci_pltfm_init() call could be put into > >> one line. Thank Ludovic Desroches. > >> > >> Since v1: > >> - add new patch03 to factorise sdhci_msm_pdata outisde of sdhci_msm_host. > >> This is to fix drivers/mmc/host/sdhci-msm.c:440:32: warning: 'msm_host' > >> is used uninitialized in this function [-Wuninitialized] > >> - Add Arnd's Ack for all patches except patch3 which is new in v2 > >> > >> > >> Jisheng Zhang (13): > >> mmc: sdhci-bcm2835: use sdhci_pltfm_init for private allocation > >> mmc: sdhci-esdhc-imx: use sdhci_pltfm_init for private allocation > >> mmc: sdhci-msm: factorise sdhci_msm_pdata outisde of sdhci_msm_host > >> mmc: sdhci-msm: use sdhci_pltfm_init for private allocation > >> mmc: sdhci-of-arasan: fix clk issue in sdhci_arasan_remove() > >> mmc: sdhci-of-arasan: use sdhci_pltfm_init for private allocation > >> mmc: sdhci-of-at91: use sdhci_pltfm_init for private allocation > >> mmc: sdhci-of-esdhc: use sdhci_pltfm_init for private allocation > >> mmc: sdhci-pxav3: use sdhci_pltfm_init for private allocation > >> mmc: sdhci-st: use sdhci_pltfm_init for private allocation > >> mmc: sdhci-tegra: use sdhci_pltfm_init for private allocation > >> mmc: sdhci-pxav2: remove unnecessary assignment of pltfm_host->priv > >> mmc: sdhci-pltfm: remove priv variable from sdhci_pltfm_host > >> > >> drivers/mmc/host/sdhci-bcm2835.c | 14 +++---------- > >> drivers/mmc/host/sdhci-esdhc-imx.c | 38 ++++++++++++++++-------------------- > >> drivers/mmc/host/sdhci-msm.c | 25 +++++++++++------------- > >> drivers/mmc/host/sdhci-of-arasan.c | 33 +++++++++++++++---------------- > >> drivers/mmc/host/sdhci-of-at91.c | 33 ++++++++++++++----------------- > >> drivers/mmc/host/sdhci-of-esdhc.c | 19 +++++++++--------- > >> drivers/mmc/host/sdhci-pltfm.h | 1 - > >> drivers/mmc/host/sdhci-pxav2.c | 1 - > >> drivers/mmc/host/sdhci-pxav3.c | 20 ++++++++----------- > >> drivers/mmc/host/sdhci-st.c | 40 +++++++++++++++++++------------------- > >> drivers/mmc/host/sdhci-tegra.c | 21 +++++++------------- > >> 11 files changed, 106 insertions(+), 139 deletions(-) > >> > >> -- > >> 2.7.0 > >> > > > > To avoid confusions. I don't intend to pick up any further sdhci > > patches, unless they are acked by Adrian Hunter. > > The patches look OK, although patch 6 doesn't apply cleanly anymore. > Nevertheless: Sorry for being late. I'm just back from vacation. Thank you very much for reviewing! I'll send a new series based on Ulf's next branch. > > Acked-by: Adrian Hunter > > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html