From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932629AbcBPOba (ORCPT ); Tue, 16 Feb 2016 09:31:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47849 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932483AbcBPOb3 (ORCPT ); Tue, 16 Feb 2016 09:31:29 -0500 Date: Tue, 16 Feb 2016 12:31:26 -0200 From: Arnaldo Carvalho de Melo To: Stephane Eranian Cc: linux-kernel@vger.kernel.org, peterz@infradead.org, mingo@elte.hu, ak@linux.intel.com, kan.liang@intel.com, jolsa@redhat.com, namhyung@kernel.org, adrian.hunter@intel.com, dsahern@gmail.com Subject: Re: [PATCH] perf/jvmti: add check for java alternatives cmd in Makefile Message-ID: <20160216143126.GA8405@redhat.com> References: <1455604661-9357-1-git-send-email-eranian@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1455604661-9357-1-git-send-email-eranian@google.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.20 (2009-12-10) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, Feb 16, 2016 at 07:37:41AM +0100, Stephane Eranian escreveu: > This patch modifies the jvmti makefile to check > if /usr/sbin/java-update-alternatives is present. > If so, then use it, if not then use the altenatives > command. This helps handle the difference between > Ubuntu and Fedora Linux distributions. Thanks, tested and applied. We need tho to better integrate it with the 'make install' target, so that it gets built and installed, this way it will end up packaged by distros. That, together with documentation should be enough as a first step to ease usage in a more widespread way. What do you think? - Arnaldo