From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932319AbcBPPqr (ORCPT ); Tue, 16 Feb 2016 10:46:47 -0500 Received: from mail-pf0-f177.google.com ([209.85.192.177]:35376 "EHLO mail-pf0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755294AbcBPPqp (ORCPT ); Tue, 16 Feb 2016 10:46:45 -0500 Date: Wed, 17 Feb 2016 00:44:50 +0900 From: Sergey Senozhatsky To: Petr Mladek Cc: Sergey Senozhatsky , Andrew Morton , Jan Kara , Tejun Heo , Kyle McMartin , Dave Jones , Calvin Owens , linux-kernel@vger.kernel.org, Sergey Senozhatsky Subject: Re: [PATCH v4 3/3] printk: check CON_ENABLED in have_callable_console() Message-ID: <20160216154450.GA542@swordfish> References: <1455302232-2252-1-git-send-email-sergey.senozhatsky@gmail.com> <1455302232-2252-4-git-send-email-sergey.senozhatsky@gmail.com> <20160216144402.GV12548@pathway.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160216144402.GV12548@pathway.suse.cz> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (02/16/16 15:44), Petr Mladek wrote: > On Sat 2016-02-13 03:37:12, Sergey Senozhatsky wrote: > > have_callable_console() must also test CON_ENABLED bit, not just > > CON_ANYTIME. We may have disabled CON_ANYTIME console so printk > > can wrongly assume that it's safe to call_console_drivers(). > > > > Signed-off-by: Sergey Senozhatsky > > Makes perfect sense. > > Reviewed-by: Petr Mladek thanks. -ss