Re: [PATCH v6 25/25] perf top: Add --hierarchy option

Namhyung Kim
2016-02-21T18:11:32Z

On Sun, Feb 21, 2016 at 12:19:29AM +0100, Jiri Olsa wrote:
> On Tue, Feb 16, 2016 at 11:08:43PM +0900, Namhyung Kim wrote:
> > Support hierarchy output for perf-top using --hierarchy option.
> >
> > Acked-by: Pekka Enberg <penberg@kernel.org>
> > Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> > ---
> > tools/perf/Documentation/perf-top.txt | 3 +++
> > tools/perf/builtin-top.c | 15 +++++++++++++++
> > 2 files changed, 18 insertions(+)
> >
> > diff --git a/tools/perf/Documentation/perf-top.txt b/tools/perf/Documentation/perf-top.txt
> > index b0e60e17db38..19f046f027cd 100644
> > --- a/tools/perf/Documentation/perf-top.txt
> > +++ b/tools/perf/Documentation/perf-top.txt
> > @@ -233,6 +233,9 @@ Default is to monitor all CPUS.
> > --raw-trace::
> > When displaying traceevent output, do not use print fmt or plugins.
> >
> > +--hierarchy::
> > + Enable hierarchy output.
> > +
> > INTERACTIVE PROMPTING KEYS
> > --------------------------
> >
> > diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
> > index a75de3940b97..b86b623e8799 100644
> > --- a/tools/perf/builtin-top.c
> > +++ b/tools/perf/builtin-top.c
> > @@ -1214,6 +1214,8 @@ int cmd_top(int argc, const char **argv, const char *prefix __maybe_unused)
> > parse_branch_stack),
> > OPT_BOOLEAN(0, "raw-trace", &symbol_conf.raw_trace,
> > "Show raw trace event output (do not use print fmt or plugins)"),
> > + OPT_BOOLEAN(0, "hierarchy", &symbol_conf.report_hierarchy,
> > + "Show entries in a hierarchy"),
>
> hum, I'm not getting --children (default) output with hierarchy?
>
> I can't see this was intentional.. haven't found the reason yet

Currently the hierarchy mode disables the children mode. This is for
simplicity and I didn't test the combination thoroughly although it
would work. Maybe we can remove the restriction later, but I think
it'd be better to start with a simple choice.

Thanks,
Namhyung