* [PATCH v2] [media] v4l2-async: Don't fail if registered_async isn't implemented
@ 2016-02-16 20:03 Javier Martinez Canillas
2016-02-16 20:11 ` Benoit Parrot
2016-02-17 9:38 ` Sakari Ailus
0 siblings, 2 replies; 3+ messages in thread
From: Javier Martinez Canillas @ 2016-02-16 20:03 UTC (permalink / raw)
To: linux-kernel
Cc: Benoit Parrot, Javier Martinez Canillas, Sakari Ailus,
Mauro Carvalho Chehab, Bryan Wu, Laurent Pinchart, linux-media
After sub-dev registration in v4l2_async_test_notify(), the v4l2-async
core calls the registered_async callback but if a sub-dev driver does
not implement it, v4l2_subdev_call() will return a -ENOIOCTLCMD which
should not be considered an error.
Reported-by: Benoit Parrot <bparrot@ti.com>
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
Changes in v2:
- Check the return of v4l2_subdev_call (Benoit).
drivers/media/v4l2-core/v4l2-async.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/v4l2-core/v4l2-async.c b/drivers/media/v4l2-core/v4l2-async.c
index 716bfd47daab..a4b224d92572 100644
--- a/drivers/media/v4l2-core/v4l2-async.c
+++ b/drivers/media/v4l2-core/v4l2-async.c
@@ -120,7 +120,7 @@ static int v4l2_async_test_notify(struct v4l2_async_notifier *notifier,
}
ret = v4l2_subdev_call(sd, core, registered_async);
- if (ret < 0) {
+ if (ret < 0 && ret != -ENOIOCTLCMD) {
if (notifier->unbind)
notifier->unbind(notifier, sd, asd);
return ret;
--
2.5.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] [media] v4l2-async: Don't fail if registered_async isn't implemented
2016-02-16 20:03 [PATCH v2] [media] v4l2-async: Don't fail if registered_async isn't implemented Javier Martinez Canillas
@ 2016-02-16 20:11 ` Benoit Parrot
2016-02-17 9:38 ` Sakari Ailus
1 sibling, 0 replies; 3+ messages in thread
From: Benoit Parrot @ 2016-02-16 20:11 UTC (permalink / raw)
To: Javier Martinez Canillas
Cc: linux-kernel, Sakari Ailus, Mauro Carvalho Chehab, Bryan Wu,
Laurent Pinchart, linux-media
Tested-by: Benoit Parrot <bparrot@ti.com>
Javier Martinez Canillas <javier@osg.samsung.com> wrote on Tue [2016-Feb-16 17:03:21 -0300]:
> After sub-dev registration in v4l2_async_test_notify(), the v4l2-async
> core calls the registered_async callback but if a sub-dev driver does
> not implement it, v4l2_subdev_call() will return a -ENOIOCTLCMD which
> should not be considered an error.
>
> Reported-by: Benoit Parrot <bparrot@ti.com>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> ---
>
> Changes in v2:
> - Check the return of v4l2_subdev_call (Benoit).
>
> drivers/media/v4l2-core/v4l2-async.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/v4l2-core/v4l2-async.c b/drivers/media/v4l2-core/v4l2-async.c
> index 716bfd47daab..a4b224d92572 100644
> --- a/drivers/media/v4l2-core/v4l2-async.c
> +++ b/drivers/media/v4l2-core/v4l2-async.c
> @@ -120,7 +120,7 @@ static int v4l2_async_test_notify(struct v4l2_async_notifier *notifier,
> }
>
> ret = v4l2_subdev_call(sd, core, registered_async);
> - if (ret < 0) {
> + if (ret < 0 && ret != -ENOIOCTLCMD) {
> if (notifier->unbind)
> notifier->unbind(notifier, sd, asd);
> return ret;
> --
> 2.5.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] [media] v4l2-async: Don't fail if registered_async isn't implemented
2016-02-16 20:03 [PATCH v2] [media] v4l2-async: Don't fail if registered_async isn't implemented Javier Martinez Canillas
2016-02-16 20:11 ` Benoit Parrot
@ 2016-02-17 9:38 ` Sakari Ailus
1 sibling, 0 replies; 3+ messages in thread
From: Sakari Ailus @ 2016-02-17 9:38 UTC (permalink / raw)
To: Javier Martinez Canillas
Cc: linux-kernel, Benoit Parrot, Mauro Carvalho Chehab, Bryan Wu,
Laurent Pinchart, linux-media
On Tue, Feb 16, 2016 at 05:03:21PM -0300, Javier Martinez Canillas wrote:
> After sub-dev registration in v4l2_async_test_notify(), the v4l2-async
> core calls the registered_async callback but if a sub-dev driver does
> not implement it, v4l2_subdev_call() will return a -ENOIOCTLCMD which
> should not be considered an error.
>
> Reported-by: Benoit Parrot <bparrot@ti.com>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
--
Sakari Ailus
e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-17 9:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-16 20:03 [PATCH v2] [media] v4l2-async: Don't fail if registered_async isn't implemented Javier Martinez Canillas
2016-02-16 20:11 ` Benoit Parrot
2016-02-17 9:38 ` Sakari Ailus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox