From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965191AbcBQE1Y (ORCPT ); Tue, 16 Feb 2016 23:27:24 -0500 Received: from mail-pa0-f42.google.com ([209.85.220.42]:34761 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755530AbcBQE1X (ORCPT ); Tue, 16 Feb 2016 23:27:23 -0500 Date: Tue, 16 Feb 2016 20:27:34 -0800 From: Stephen Hemminger To: Vivien Didelot Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Ido Schimmel , Florian Fainelli , Andrew Lunn Subject: Re: [PATCH net-next] net: bridge: log port STP state on change Message-ID: <20160216202734.4f86a80c@xeon-e3> In-Reply-To: <1455635391-25311-1-git-send-email-vivien.didelot@savoirfairelinux.com> References: <1455635391-25311-1-git-send-email-vivien.didelot@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 16 Feb 2016 10:09:51 -0500 Vivien Didelot wrote: > Remove the shared br_log_state function and print the info directly in > br_set_state, where the net_bridge_port state is actually changed. > > Signed-off-by: Vivien Didelot > --- Looks good and fixes the weird case where set_state fails then a log message would still be printed.