From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933578AbcBQAk4 (ORCPT ); Tue, 16 Feb 2016 19:40:56 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:34093 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933437AbcBQAkx (ORCPT ); Tue, 16 Feb 2016 19:40:53 -0500 Date: Tue, 16 Feb 2016 16:40:52 -0800 From: Greg Kroah-Hartman To: Victor Dodon Cc: linux-kernel@vger.kernel.org, Matthew Dharm , linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net, Gwendal Grignou Subject: Re: [PATCH] usb: storage: make US_DEBUGPX print with LOGLEVEL_DEBUG Message-ID: <20160217004052.GB3037@kroah.com> References: <20160211001343.GA133746@printesoi1.mtv.corp.google.com> <20160215012021.GG26844@kroah.com> <20160216234539.GA142596@printesoi1.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160216234539.GA142596@printesoi1.mtv.corp.google.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 16, 2016 at 03:45:39PM -0800, Victor Dodon wrote: > On Sun, Feb 14, 2016 at 05:20:21PM -0800, Greg Kroah-Hartman wrote: > > On Wed, Feb 10, 2016 at 04:13:43PM -0800, Victor Dodon wrote: > > > The US_DEBUGPX macro uses printk without specifying a kernel log level, so > > > the default kernel log level is used, which may not match LOGLEVEL_DEBUG > > > used in usb_stor_dbg. Use printk_emit with LOGLEVEL_DEBUG instead. > > > > > > Signed-off-by: Victor Dodon > > > --- > > > drivers/usb/storage/debug.h | 10 ++++++++-- > > > 1 file changed, 8 insertions(+), 2 deletions(-) > > > > Can you just get rid of US_DEBUGPX() entirely please? It shouldn't be > > needed anymore, just use usb_stor_dbg() instead. > > Using usb_stor_dbg() instead of US_DEBUGPX() in > usb_stor_show_command() prints one byte per line with the full syslog > header, like this: > > 7,0,Feb 16 14:30:41,ubuntu,kernel:,[ 422.876236] Command > TEST_UNIT_READY (6 bytes) > 7,0,Feb 16 14:30:41,ubuntu,kernel:,[ 422.876242] bytes: > 7,0,Feb 16 14:30:41,ubuntu,kernel:,[ 422.876249] 00 > 7,0,Feb 16 14:30:41,ubuntu,kernel:,[ 422.876255] 00 > 7,0,Feb 16 14:30:41,ubuntu,kernel:,[ 422.876261] 00 > 7,0,Feb 16 14:30:41,ubuntu,kernel:,[ 422.876267] 00 > 7,0,Feb 16 14:30:41,ubuntu,kernel:,[ 422.876273] 00 > 7,0,Feb 16 14:30:41,ubuntu,kernel:,[ 422.876279] 00 > 7,0,Feb 16 14:30:41,ubuntu,kernel:,[ 422.876285] > > instead of the desired: > > 7,0,Feb 16 14:30:41,ubuntu,kernel:,[ 422.876236] Command > TEST_UNIT_READY (6 bytes) > 7,0,Feb 16 14:30:41,ubuntu,kernel:,[ 422.876242] bytes: > 7,0,Feb 16 14:30:41,ubuntu,kernel:,[ 422.876249] 00 00 00 00 00 00 > > this is why I think the US_DEBUGPX() macro is still needed. Nope, fix the call to use the proper printk % modifier instead and you will be fine. No need to keep reinventing the wheel, we have had support for byte streams in messages for probably over a decade now... Nice try though :) thanks, greg k-h