From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S965185AbcBQDyo (ORCPT <rfc822;w@1wt.eu>);
	Tue, 16 Feb 2016 22:54:44 -0500
Received: from mail-pf0-f176.google.com ([209.85.192.176]:36519 "EHLO
	mail-pf0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S965020AbcBQDym (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 16 Feb 2016 22:54:42 -0500
Date: Wed, 17 Feb 2016 12:55:58 +0900
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: xuyiping <xuyiping@hisilicon.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
        YiPing Xu <xuyiping@huawei.com>, minchan@kernel.org, ngupta@vflare.org,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        suzhuangluan@hisilicon.com, puck.chen@hisilicon.com,
        dan.zhao@hisilicon.com
Subject: Re: [PATCH] zsmalloc: drop unused member 'mapping_area->huge'
Message-ID: <20160217035558.GA15278@swordfish>
References: <1455674199-6227-1-git-send-email-xuyiping@huawei.com>
 <20160217022552.GB535@swordfish>
 <56C3E91B.1030101@hisilicon.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <56C3E91B.1030101@hisilicon.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On (02/17/16 11:29), xuyiping wrote:
[..]
> 
> 	if (off + class->size <= PAGE_SIZE) {
> 
> for huge object, the code will get into this branch, there is no more huge
> object process in __zs_map_object.

correct, well, techically, it's not about huge objects, but objects that span
page boundaries. we can have objects of pretty small sizes being split between
pages, for example size:1536 and offset:3072, etc.

	-ss