From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965129AbcBQFTn (ORCPT ); Wed, 17 Feb 2016 00:19:43 -0500 Received: from mail-pf0-f171.google.com ([209.85.192.171]:34270 "EHLO mail-pf0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964975AbcBQFTm (ORCPT ); Wed, 17 Feb 2016 00:19:42 -0500 Date: Wed, 17 Feb 2016 14:20:58 +0900 From: Sergey Senozhatsky To: YiPing Xu Cc: minchan@kernel.org, ngupta@vflare.org, sergey.senozhatsky.work@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, suzhuangluan@hisilicon.com, puck.chen@hisilicon.com, dan.zhao@hisilicon.com, Andrew Morton Subject: Re: [PATCH] zsmalloc: drop unused member 'mapping_area->huge' Message-ID: <20160217052058.GA620@swordfish> References: <1455674199-6227-1-git-send-email-xuyiping@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1455674199-6227-1-git-send-email-xuyiping@huawei.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (02/17/16 09:56), YiPing Xu wrote: > When unmapping a huge class page in zs_unmap_object, the page will > be unmapped by kmap_atomic. the "!area->huge" branch in > __zs_unmap_object is alway true, and no code set "area->huge" now, > so we can drop it. > the patch looks good to me, thanks. Reviewed-by: Sergey Senozhatsky -ss > Signed-off-by: YiPing Xu > --- > mm/zsmalloc.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c > index 2d7c4c1..43e4cbc 100644 > --- a/mm/zsmalloc.c > +++ b/mm/zsmalloc.c > @@ -281,7 +281,6 @@ struct mapping_area { > #endif > char *vm_addr; /* address of kmap_atomic()'ed pages */ > enum zs_mapmode vm_mm; /* mapping mode */ > - bool huge; > }; > > static int create_handle_cache(struct zs_pool *pool) > @@ -1127,11 +1126,9 @@ static void __zs_unmap_object(struct mapping_area *area, > goto out; > > buf = area->vm_buf; > - if (!area->huge) { > - buf = buf + ZS_HANDLE_SIZE; > - size -= ZS_HANDLE_SIZE; > - off += ZS_HANDLE_SIZE; > - } > + buf = buf + ZS_HANDLE_SIZE; > + size -= ZS_HANDLE_SIZE; > + off += ZS_HANDLE_SIZE; > > sizes[0] = PAGE_SIZE - off; > sizes[1] = size - sizes[0]; > -- > 1.8.3.2 >