From: Darren Hart <dvhart@infradead.org>
To: Oleksandr Natalenko <oleksandr@natalenko.name>
Cc: Corentin Chary <corentin.chary@gmail.com>,
acpi4asus-user@lists.sourceforge.net,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] asus-nb-wmi: add wapf=4 quirk for ASUS X75VD
Date: Tue, 16 Feb 2016 23:33:23 -0800 [thread overview]
Message-ID: <20160217073323.GD22091@dvhart-mobl5.amr.corp.intel.com> (raw)
In-Reply-To: <0cbfffd61495fe8bc060c53b424d9391@natalenko.name>
On Fri, Feb 12, 2016 at 03:35:21PM +0200, Oleksandr Natalenko wrote:
> Wi-Fi on ASUS X75VD laptop does not work unless asus_nb_wmi module
> is loaded with wapf=4 option. Add quirk for this.
Concept is fine, checkpatch complains bitterly about whitespace. Please ensure
you are not adding spaces at the beginning of lines in your editor or in your
patch submission process.
>
> ---
> drivers/platform/x86/asus-nb-wmi.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/platform/x86/asus-nb-wmi.c
> b/drivers/platform/x86/asus-nb-wmi.c
> index 131fee2..091ca7a 100644
> --- a/drivers/platform/x86/asus-nb-wmi.c
> +++ b/drivers/platform/x86/asus-nb-wmi.c
> @@ -272,6 +272,15 @@ static const struct dmi_system_id asus_quirks[] = {
> },
> {
> .callback = dmi_matched,
> + .ident = "ASUSTeK COMPUTER INC. X75VD",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "X75VD"),
> + },
> + .driver_data = &quirk_asus_wapf4,
> + },
> + {
> + .callback = dmi_matched,
> .ident = "ASUSTeK COMPUTER INC. 1015E",
> .matches = {
> DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> --
> 2.7.1
>
--
Darren Hart
Intel Open Source Technology Center
prev parent reply other threads:[~2016-02-17 7:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-12 13:35 [PATCH] asus-nb-wmi: add wapf=4 quirk for ASUS X75VD Oleksandr Natalenko
2016-02-17 7:33 ` Darren Hart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160217073323.GD22091@dvhart-mobl5.amr.corp.intel.com \
--to=dvhart@infradead.org \
--cc=acpi4asus-user@lists.sourceforge.net \
--cc=corentin.chary@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleksandr@natalenko.name \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox