From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756851AbcBQJ0X (ORCPT ); Wed, 17 Feb 2016 04:26:23 -0500 Received: from mail-wm0-f51.google.com ([74.125.82.51]:32808 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756785AbcBQJ0U (ORCPT ); Wed, 17 Feb 2016 04:26:20 -0500 Date: Wed, 17 Feb 2016 10:26:16 +0100 From: Ingo Molnar To: Alexander Kuleshov Cc: Ingo Molnar , Thomas Gleixner , "H . Peter Anvin" , x86@kernel.org, Borislav Petkov , Joerg Roedel , Dave Young , Andrew Morton , Jiri Kosina , Baoquan He , Mark Salter , linux-kernel@vger.kernel.org Subject: Re: [PATCH v5] x86/setup: get ramdisk parameters only once Message-ID: <20160217092616.GA18628@gmail.com> References: <1455700391-11702-1-git-send-email-kuleshovmail@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1455700391-11702-1-git-send-email-kuleshovmail@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Alexander Kuleshov wrote: > - early_reserve_initrd(); > + if (!boot_params.hdr.type_of_loader || !ramdisk_image.start_addr || !ramdisk_image.size) > + ramdisk_image.reserve_ramdisk = false; /* No initrd provided by bootloader */ > + else > + memblock_reserve(ramdisk_image.start_addr, ramdisk_image.size); ... and _now_ it's clear that it makes sense to keep early_reserve_initrd(), move that new chunk of code to it and pass in the ramdisk structure. Also, please rename the too long 'ramdisk_image' local variable to something shorter: 'rd' is commonly used - but the original 'ramdisk' name was fine too. Thanks, Ingo