From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757087AbcBQJg4 (ORCPT ); Wed, 17 Feb 2016 04:36:56 -0500 Received: from mga02.intel.com ([134.134.136.20]:61420 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756730AbcBQJgy (ORCPT ); Wed, 17 Feb 2016 04:36:54 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,459,1449561600"; d="scan'208";a="916690345" Date: Wed, 17 Feb 2016 11:36:23 +0200 From: Jarkko Sakkinen To: Jason Gunthorpe Cc: Peter Huewe , tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [tpmdd-devel] [PATCH] tpm_crb: fix bad name pointer usage with struct resource Message-ID: <20160217093623.GA9831@intel.com> References: <1455668874-13261-1-git-send-email-jarkko.sakkinen@linux.intel.com> <20160217045219.GA26086@obsidianresearch.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160217045219.GA26086@obsidianresearch.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 16, 2016 at 09:52:19PM -0700, Jason Gunthorpe wrote: > On Wed, Feb 17, 2016 at 02:27:54AM +0200, Jarkko Sakkinen wrote: > > - if (acpi_dev_resource_memory(ares, &res)) > > + if (acpi_dev_resource_memory(ares, &res)) { > > + res.name = NULL; > > What? How is this not a bug in acpi_dev_resource_memory? Maybe it > needs to memcpy into devm allocated memory instead, but I'm confused > how/why/when acpi could free name. > > The same code exists in tpm_tis as well. That was the only way to fix the garbage issue. I would keep things this way for Linux 4.5. /Jarkko