From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934367AbcBQMts (ORCPT ); Wed, 17 Feb 2016 07:49:48 -0500 Received: from mail-db3on0063.outbound.protection.outlook.com ([157.55.234.63]:50959 "EHLO emea01-db3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S934193AbcBQMtp (ORCPT ); Wed, 17 Feb 2016 07:49:45 -0500 Authentication-Results: savoirfairelinux.com; dkim=none (message not signed) header.d=none;savoirfairelinux.com; dmarc=none action=none header.from=mellanox.com; Date: Wed, 17 Feb 2016 12:14:27 +0200 From: Ido Schimmel To: Vivien Didelot CC: , , , "David S. Miller" , Stephen Hemminger , Florian Fainelli , Andrew Lunn Subject: Re: [PATCH net-next] net: bridge: log port STP state on change Message-ID: <20160217101427.GA388@colbert.mtl.com> References: <1455635391-25311-1-git-send-email-vivien.didelot@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1455635391-25311-1-git-send-email-vivien.didelot@savoirfairelinux.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [193.47.165.251] X-ClientProxiedBy: VI1PR02CA0010.eurprd02.prod.outlook.com (25.162.7.148) To VI1PR05MB0992.eurprd05.prod.outlook.com (25.162.11.14) X-Microsoft-Exchange-Diagnostics: 1;VI1PR05MB0992;2:oOy+WJzTBL6XOdRPPqqP15Xzc1LO+KNAuY5rFG8nih/3qXg0I8fhsidDc9G8FCLYjd24PxHCqtfC12ZLOEcD4oD+pejw6i2xbSFNptENgQPxU+G8xJB7gwzzu2U/EkdGHnv0zc1aoz0r+OnswiDLZw==;3:z5CnHL7tcUcIlBRR4uurpFgUSzHhgu0XHnngl3/M4wWyTnLj3m8+SlJYtZgBtftmOktNNrm2MQyG3b1IpI/xOCdgYhpK2nKWHKXpz11c0naYPp0caaCrY5g9bKhD+8is;25:MF/cKDQbZUGASVlQZAR8DZv2EyBrH2UEkbfDZwKQaXqFwbV5esK3IpSw9t850HeS3swWnvEXZwPrKrAom5Ch5RvzaXO1h6zHI1plbzk6UaJKsKLaD2he65ULfqdR/EoyZcbJOAI3a5ShVaD7CiZhxeHJR/yxk1HXzu4RRtQnBSNOI091K5KZrXDG8ggA12BCLd8MRi3QvLBBTGmC5uN5Y053VRMwAcE8uuLxxVHW5E9X79THnKB0Ap9lUOiMC5UcemTwuWkFVz8aW5SZiqaL8xPObg4A4IlKUu0wCxmMstsvT9NZ5du1ZDVdrMen6Ncq X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:VI1PR05MB0992; X-MS-Office365-Filtering-Correlation-Id: 47347b4a-44af-4816-3536-08d337833dfb X-Microsoft-Exchange-Diagnostics: 1;VI1PR05MB0992;20:WrXQ4sN1v69V9/tIdYHb3L1rgHVVAkzx8Bi/ygtUuZXLcpsqP8hmsU+xEQ+tBnOL/WkDlWGPy1dZYGmMcHzElede8GVZjKfTocY1bP4bc0avd4b4aD8wvdZamgAxs7Z/oLQXHZeOqcUdi92lb1LGinzhA/LMTSotGLJhrjAdbyafFxRiNDgE+PaRDol34CXLXcQph9SbY+uou7n50pbrJ4UDJXaZHgSwuPScXJMcGMBFhWKG1u2CsLWtyJOtz2uAQn91zunlTnCRCa2diFvx5EJhji5mrNhcEyniymtvid0ipKpR7dRcP+rfQvSGgFgNjLX1Qc69yHgHV37sEbJYlTrAEzUevlU6a78mApXfonzvkSR9w7W05u2ZHlb9g+SKTkvQvn3UJ9AlAagnwwB+DXDTQ07JWVD2WFTAbkWR4/L+WGlMHvghugHFRN+aZFSZ2oAip4rz6PWvCaWDbAw+2wB7RE+WbBEFI2eTGvO4dnB5nP6QxTekYSmf/IubNJTq;4:piU3Wu6z3HZf9him1/kHV9qhVwTvZf9KDgYhY4gynXK0Vki9cOZ4xa0gRoVB4tjoc+PpagJi9vqYaJYBrqRly2PyaFObrdo4jMbPwsKkzjn0XlOcZYJaS3RudWADMkoqP2kinlIeFyi7K6+RAXCcEczgU4x5QGrEb+q+dDpo53ZxYPBZrW35mnz776pQ01luNYMqzqP8JEylDe3L4p7LeEsLLQeQjodALsmlEJ4WeCHnxwPtPrntpDjRd4vjGG2BgvzKbvzitTAP/jAC6Uu5xheA221Ns3h8B+5A6qJ4/BuJe9a81jGVDmvypd3rgaxm6dQbLeQwtSuyDSdTw7MqPHZZBkLJaH8IdSKMKlu/0pDrSkmN4MttBL48FKO8Z/fj X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:VI1PR05MB0992;BCL:0;PCL:0;RULEID:;SRVR:VI1PR05MB0992; X-Forefront-PRVS: 085551F5A8 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(6069001)(24454002)(23726003)(586003)(1096002)(1076002)(2906002)(6116002)(97756001)(5004730100002)(77096005)(4326007)(47776003)(50466002)(5008740100001)(19580405001)(4001350100001)(87976001)(40100003)(76176999)(46406003)(122386002)(83506001)(92566002)(5001960100002)(2950100001)(42186005)(86362001)(76506005)(33656002)(54356999)(19580395003)(3846002)(110136002)(66066001)(50986999)(189998001);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR05MB0992;H:localhost;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;VI1PR05MB0992;23:IaOzOYtK5Yc/Rl5U/qoK+Ul1JeEw0Kn/MnEWAtwrr?= =?us-ascii?Q?yD3Em8GIb+S/GWraAG2a4vEZyESSKh0Wk+IVm1N5ETaP21sB6pBPmKR8bsHY?= =?us-ascii?Q?fHgS1Ie/2GpaK+1fN6lJUl7rUC+NrpZKCClNinUZ8SG+Z6wQcLCl3oVYSTDO?= =?us-ascii?Q?20CwUeTHpirykuhihPCwvKmfZriLCws09s75gUXT2xgiPG5jqgfGOmHGWYx5?= =?us-ascii?Q?D1IPbptt22DEpb4v0D8GDGQQbSkjcX0ah4t3tR3GGstYx/7HMGQo5bLhGyrJ?= =?us-ascii?Q?kzFe4adUil8NPqMmAkxaCXXXrAm20u++jpFIrVpbLG7cuKvBD30TMz9W+aD0?= =?us-ascii?Q?sUzOAxM3Kug4JXT/cpqY2MnOEnIKhVZ1UH1QmHKm8VcKDfPi0PdoxOEx+w8v?= =?us-ascii?Q?mn+hprXw+vIegtEvpg2jxeHcEEP7Eqh/9bmlxW7iDNqJApN0HXrgZPhKR8Yr?= =?us-ascii?Q?2iBnDmmWHfzCNBiH3Yt2kNJBUPNZNutUOcxvCUkqu7phzrmbIY18z66ObGh1?= =?us-ascii?Q?n0BDsHrr5fy1u8IMrBRS685NZ8yEAfQo2PdC+P6DL0MqDhOTChfTQcQPY67a?= =?us-ascii?Q?c7ftZAC+KZ90/9icou8LZBIS/8Ls2oBcDgBGMRXKyFRI+g7Cy9YD4DFRIEkk?= =?us-ascii?Q?rO2Zj6Twe5jnC4lwd5Hi4JzEceB9sEjH69yKttTjsEPflixTYZLUUXomSyK1?= =?us-ascii?Q?xf/Fu/SIm+yDqdO8Ww+ZvbN9JV5ovkqxEzAaNtoCVGDy8c7k00aqsv3eJmeu?= =?us-ascii?Q?K4v6EfSl57srMpRhe7Hc7Km1uQmKj8F/JeEuY56+NLVcQx8D7vSnt7IzXLnB?= =?us-ascii?Q?tgYYmXFKBXp0Embis57j0J6H5PVoG/zLG97RnpDcHqlNnnYv2Zh/nAHXR9V1?= =?us-ascii?Q?Du1X7W9aLlamj0y/m70c5k2s5X8hMgB97UqqzOJOFq0exscqOsQ9/0tZiZTv?= =?us-ascii?Q?telRirm3DuijxcfkKCIqGNf+idQdy4t8VHHlsPfiEMF6bHStA/61cyRMiPAz?= =?us-ascii?Q?mBpxZ+PhLTX3OAQ0cXJJksQzQjohi7VbL6YQAEvhp0HjpQ9N7KxOQGh3caOF?= =?us-ascii?Q?Uk/wIc=3D?= X-Microsoft-Exchange-Diagnostics: 1;VI1PR05MB0992;5:AQlNZoM9aqoo6oGfanX98A8yq6N6YuGUtaSGMJrbEh/MdAr8LsRj+lBh8m6r2O6LR2+FG4k6h9kQFqx5WIlPFBP8Ksczh4dF7S0+IAE38xPQID48tCh1Y8vhx0/UeISPv3M7W4/HY/GGT2r85HHoMw==;24:83MDkFsKQLy0AVQw51MnHnKRT/6JEoXsKBfqT/5Dwtxo2swfR4clE2+jf8ko1U5AXyQjS0otbMLrBA6SqcgXuKP/2Rg0XHVeLxT/Hb5C2/s= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2016 10:15:20.6832 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB0992 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Tue, Feb 16, 2016 at 05:09:51PM IST, vivien.didelot@savoirfairelinux.com wrote: >Remove the shared br_log_state function and print the info directly in >br_set_state, where the net_bridge_port state is actually changed. > >Signed-off-by: Vivien Didelot >--- Acked-by: Ido Schimmel Thanks Vivien.