From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934376AbcBQMIz (ORCPT ); Wed, 17 Feb 2016 07:08:55 -0500 Received: from mail-wm0-f53.google.com ([74.125.82.53]:34529 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934345AbcBQMIv (ORCPT ); Wed, 17 Feb 2016 07:08:51 -0500 Date: Wed, 17 Feb 2016 13:08:48 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: =?utf-8?B?TWljaGHFgiBLxJlwaWXFhA==?= Cc: Matthew Garrett , Darren Hart , Darek Stojaczyk , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 5/5] dell-wmi: support Dell Inspiron M5110 Message-ID: <20160217120848.GT1476@pali> References: <20160121090401.GR7192@pali> <1455634230-1487-1-git-send-email-kernel@kempniu.pl> <1455634230-1487-6-git-send-email-kernel@kempniu.pl> <20160216152246.GL1476@pali> <20160216220312.GB2741@eudyptula.hq.kempniu.pl> <20160217114230.GS1476@pali> <20160217120158.GA3494@eudyptula.hq.kempniu.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160217120158.GA3494@eudyptula.hq.kempniu.pl> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 17 February 2016 13:01:58 Michał Kępień wrote: > > > > > /* Shortcut and audio panel keys */ > > > > > { KE_KEY, 0xe025, { KEY_PROG4 } }, > > > > > { KE_IGNORE, 0xe026, { KEY_RESERVED } }, > > > > > + { KE_KEY, 0xe029, { KEY_PROG4 } }, > > > > > > > > Hi! Above comment (Shortcut and audio panel keys) is not relevant for > > > > this 0xe029, right? > > > > > > I believe it is relevant. The commit which added that comment > > > (f1566f0d) was made by Seth Forshee to support Dell XPS L502X. The term > > > "shortcut key" is used in the bug report linked from that commit [1], > > > but the manual for that model [2] describes the hotkey in question as > > > "Instant launch control" (page 43), so I believe both Seth's commit and > > > my patch refer to the same thing. > > > > > > [1] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/815914/comments/6 > > > [2] http://downloads.dell.com/Manuals/all-products/esuprt_laptop/esuprt_xps_laptop/xps-l502x_setup%20guide_en-us.pdf > > > > Then please split above group of keys and add comment which key is > > shortcut and which audio panel. Because now there will be three keys and > > comment just for two -- in future will not know which code 0x... is > > mapped to which key. > > Please note that except for the first 5 entries, the keymap is sorted by > event code in ascending order. I have prepared some patches which sort all event codes plus adds missing comments... So after all dell patches are in Darren tree, I will rewrite/rebase my and can send them. > If I understand correctly, doing what you ask would break that ordering: > > /* Dell Instant Launch key */ > { KE_KEY, 0xe025, { KEY_PROG4 } }, > { KE_KEY, 0xe029, { KEY_PROG4 } }, > > /* Audio panel key */ > { KE_IGNORE, 0xe026, { KEY_RESERVED } }, > > Is this acceptable? Or perhaps you had something else on your mind? Thats better, now we know which event is audio and which launch key. -- Pali Rohár pali.rohar@gmail.com