From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423109AbcBQNmp (ORCPT ); Wed, 17 Feb 2016 08:42:45 -0500 Received: from vps0.lunn.ch ([178.209.37.122]:50154 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1423084AbcBQNmo (ORCPT ); Wed, 17 Feb 2016 08:42:44 -0500 Date: Wed, 17 Feb 2016 14:42:40 +0100 From: Andrew Lunn To: Srinivas Kandagatla Cc: GregKH , maxime.ripard@free-electrons.com, wsa@the-dreams.de, broonie@kernel.org, vz@mleia.com, fd@ti.com, linux-kernel@vger.kernel.org, pantelis.antoniou@konsulko.com, bgolaszewski@baylibre.com Subject: Re: [PATCHv4 5/7] eeprom: at25: extend driver to plug into the NVMEM framework Message-ID: <20160217134240.GD17326@lunn.ch> References: <1455666097-9115-1-git-send-email-andrew@lunn.ch> <1455666097-9115-6-git-send-email-andrew@lunn.ch> <56C448CF.4070208@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56C448CF.4070208@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > >- if (!(chip.flags & EE_READONLY)) { > >- at25->bin.write = at25_bin_write; > >- at25->bin.attr.mode |= S_IWUSR; > >- } > > Above check is totally unused, probably remove it. Sorry, i don't understand. This check is being removed. Thanks Andrew