From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423058AbcBQNop (ORCPT ); Wed, 17 Feb 2016 08:44:45 -0500 Received: from mail-wm0-f46.google.com ([74.125.82.46]:36924 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1422804AbcBQNon (ORCPT ); Wed, 17 Feb 2016 08:44:43 -0500 Date: Wed, 17 Feb 2016 14:44:41 +0100 From: Michal Hocko To: Tetsuo Handa Cc: akpm@linux-foundation.org, rientjes@google.com, mgorman@suse.de, oleg@redhat.com, torvalds@linux-foundation.org, hughd@google.com, andrea@kernel.org, riel@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/6] mm,oom: exclude oom_task_origin processes if they are OOM-unkillable. Message-ID: <20160217134441.GL29196@dhcp22.suse.cz> References: <201602171928.GDE00540.SLJMOFFQOHtFVO@I-love.SAKURA.ne.jp> <201602171933.HFD51078.LOSFVMFQFOJHOt@I-love.SAKURA.ne.jp> <20160217131034.GH29196@dhcp22.suse.cz> <201602172236.FHF87070.LOVFtJSOFFMHQO@I-love.SAKURA.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201602172236.FHF87070.LOVFtJSOFFMHQO@I-love.SAKURA.ne.jp> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 17-02-16 22:36:47, Tetsuo Handa wrote: [...] > Are you suggesting something like below? > (OOM_SCORE_ADJ_MIN check needs to be done after TIF_MEMDIE check) > > enum oom_scan_t oom_scan_process_thread(struct oom_control *oc, > struct task_struct *task, unsigned long totalpages) > { > if (oom_unkillable_task(task, NULL, oc->nodemask)) > return OOM_SCAN_CONTINUE; > > /* > * This task already has access to memory reserves and is being killed. > * Don't allow any other task to have access to the reserves. > */ > if (test_tsk_thread_flag(task, TIF_MEMDIE)) { > if (!is_sysrq_oom(oc)) > return OOM_SCAN_ABORT; > } > if (!task->mm || task->signal->oom_score_adj == OOM_SCORE_ADJ_MIN) > return OOM_SCAN_CONTINUE; yes -- Michal Hocko SUSE Labs