[PATCH] usb: usbtmc: Fix disconnect/poll interaction

[PATCH] usb: usbtmc: Fix disconnect/poll interaction

[Dave Penkler]

When the device is disconnected poll waiters were not being woken.
Fixes issue in commit eb6b92ecc0f9412623ab1584ddd8389b371638d4 reported
by Oliver Neukum

Signed-off-by: Dave Penkler <dpenkler@gmail.com>
---
 drivers/usb/class/usbtmc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/class/usbtmc.c b/drivers/usb/class/usbtmc.c
index 419c72e..917a55c 100644
--- a/drivers/usb/class/usbtmc.c
+++ b/drivers/usb/class/usbtmc.c
@@ -1525,13 +1525,14 @@ static void usbtmc_disconnect(struct usb_interface *intf)
 	dev_dbg(&intf->dev, "usbtmc_disconnect called\n");
 
 	data = usb_get_intfdata(intf);
-	usbtmc_free_int(data);
 	usb_deregister_dev(intf, &usbtmc_class);
 	sysfs_remove_group(&intf->dev.kobj, &capability_attr_grp);
 	sysfs_remove_group(&intf->dev.kobj, &data_attr_grp);
 	mutex_lock(&data->io_mutex);
 	data->zombie = 1;
+	wake_up_all(&data->waitq);
 	mutex_unlock(&data->io_mutex);
+	usbtmc_free_int(data);
 	kref_put(&data->kref, usbtmc_delete);
 }
 
-- 
2.6.3

Re: [PATCH] usb: usbtmc: Fix disconnect/poll interaction

[Sergei Shtylyov]

Hello.

On 02/17/2016 07:10 PM, Dave Penkler wrote:

> When the device is disconnected poll waiters were not being woken.
> Fixes issue in commit eb6b92ecc0f9412623ab1584ddd8389b371638d4 reported

    scripts/checkpatch.pl now enforces certain commit citing format, yours 
doesn't match it, not only because you missed to specify the commit summary. :-)

> by Oliver Neukum

    Note that there are also "Fixes:" and "Reported-by:" tags for that.

> Signed-off-by: Dave Penkler <dpenkler@gmail.com>
[...]

MBR, Sergei