From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161782AbcBQS4l (ORCPT ); Wed, 17 Feb 2016 13:56:41 -0500 Received: from mail.kernel.org ([198.145.29.136]:39086 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965208AbcBQS4Z (ORCPT ); Wed, 17 Feb 2016 13:56:25 -0500 Date: Wed, 17 Feb 2016 15:56:21 -0300 From: Arnaldo Carvalho de Melo To: Andi Kleen Cc: jolsa@kernel.org, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH] perf, tools, stat: Include asm/bug.h for WARN_ON Message-ID: <20160217185621.GA9909@kernel.org> References: <1455734348-13690-1-git-send-email-andi@firstfloor.org> <20160217185209.GA9299@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160217185209.GA9299@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Feb 17, 2016 at 03:52:09PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Feb 17, 2016 at 10:39:08AM -0800, Andi Kleen escreveu: > > In my set up (separate objdir, DEBUG=1) tip perf doesn't build without this change. > > It may be that in some other setups asm/bug.h is implicitely included. > Thanks, applying your fix, after making it build on acme/perf/core: I take that back, it is already there: [acme@jouet linux]$ git blame tools/perf/builtin-stat.c | grep -w bug\.h ba6039b6c8fcc tools/perf/builtin-stat.c (Jiri Olsa 2015-11-05 15:40:55 +0100 64) #include "asm/bug.h" [acme@jouet linux]$ git log --oneline -1 ba6039b6c8fcc ba6039b6c8fc perf stat report: Add report command [acme@jouet linux]$ git tag --contains ba6039b6c8fcc v4.5-rc1 v4.5-rc2 v4.5-rc3 v4.5-rc4 [acme@jouet linux]$ - Arnaldo