From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1424480AbcBQXCi (ORCPT ); Wed, 17 Feb 2016 18:02:38 -0500 Received: from mail-yw0-f171.google.com ([209.85.161.171]:35724 "EHLO mail-yw0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1424464AbcBQXCd (ORCPT ); Wed, 17 Feb 2016 18:02:33 -0500 Date: Wed, 17 Feb 2016 18:02:31 -0500 From: Tejun Heo To: Tahsin Erdogan Cc: Jan Kara , Jens Axboe , cgroups@vger.kernel.org, "Theodore Ts'o" , Nauman Rafique , linux-kernel@vger.kernel.org, Jan Kara Subject: Re: [PATCH block/for-4.5-fixes] writeback: keep superblock pinned during cgroup writeback association switches Message-ID: <20160217230231.GC6479@mtj.duckdns.org> References: <20160215210047.GN3965@htj.duckdns.org> <20160216182457.GO3741@mtj.duckdns.org> <20160217205721.GE14140@quack.suse.cz> <20160217210744.GA6479@mtj.duckdns.org> <20160217223009.GN14140@quack.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 17, 2016 at 02:41:25PM -0800, Tahsin Erdogan wrote: > With this patch, I am starting to have issues running fsck immediately > after umount. > > *** fsck.ext4 output *** > fsck from util-linux-ng 2.17.2 > e2fsck 1.42.12-gg3 (9-Sep-2014) > Warning! /dev/sdb3 is in use. > Pass 1: Checking inodes, blocks, and sizes > Deleted inode 62346243 has zero dtime. Fix? no Yeah, that'd be one of the side effects. Will think more about it. Jan, do you know why we have both s_active and the rwsem at this point? I can't tell why both are needed. Thanks. -- tejun