From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1947993AbcBRUfq (ORCPT ); Thu, 18 Feb 2016 15:35:46 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:47024 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1424609AbcBRUfo convert rfc822-to-8bit (ORCPT ); Thu, 18 Feb 2016 15:35:44 -0500 Date: Thu, 18 Feb 2016 15:35:42 -0500 (EST) Message-Id: <20160218.153542.67284853154438064.davem@davemloft.net> To: linus.luessing@c0d3.blue Cc: netdev@vger.kernel.org, stephen@networkplumber.org, bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org, sgunderson@bigfoot.com, noltari@gmail.com, tom@herbertland.com Subject: Re: [PATCH] net: fix bridge multicast packet checksum validation From: David Miller In-Reply-To: <1455502026-23144-1-git-send-email-linus.luessing@c0d3.blue> References: <1455502026-23144-1-git-send-email-linus.luessing@c0d3.blue> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 18 Feb 2016 12:35:44 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Linus Lüssing Date: Mon, 15 Feb 2016 03:07:06 +0100 > @@ -4084,10 +4089,22 @@ struct sk_buff *skb_checksum_trimmed(struct sk_buff *skb, > if (!pskb_may_pull(skb_chk, offset)) > goto err; > > - __skb_pull(skb_chk, offset); > + ip_summed = skb->ip_summed; > + csum_valid = skb->csum_valid; > + csum_level = skb->csum_level; > + csum_bad = skb->csum_bad; > + csum = skb->csum; > + > + skb_pull_rcsum(skb_chk, offset); > ret = skb_chkf(skb_chk); > __skb_push(skb_chk, offset); > > + skb->ip_summed = ip_summed; > + skb->csum_valid = csum_valid; > + skb->csum_level = csum_level; > + skb->csum_bad = csum_bad; > + skb->csum = csum; > + There really has to be a better way to fix this :-/