From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933828AbcBRHuu (ORCPT ); Thu, 18 Feb 2016 02:50:50 -0500 Received: from mail-wm0-f41.google.com ([74.125.82.41]:35508 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933506AbcBRHus (ORCPT ); Thu, 18 Feb 2016 02:50:48 -0500 Date: Thu, 18 Feb 2016 08:50:43 +0100 From: Ingo Molnar To: Andi Kleen Cc: Thomas Gleixner , Stephane Eranian , LKML , Peter Zijlstra , Borislav Petkov , Harish Chegondi , Kan Liang , Andi Kleen Subject: Re: [patch 07/11] x86/perf/uncore: Track packages not per cpu data Message-ID: <20160218075043.GA14911@gmail.com> References: <20160217132903.767990400@linutronix.de> <20160217133932.279611021@linutronix.de> <878u2j9gjr.fsf@tassilo.jf.intel.com> <20160217221640.GD5083@two.firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160217221640.GD5083@two.firstfloor.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Andi Kleen wrote: > > Do you have any data to back that up or is that just "believe" ? > > I've seen systems with discontiguous apic ids before. > > It is obvious if you consider setups with node hotplug. > > BTW reading this thread you don't seem interested in any code review feedback, > attacking everyone, [...] I've not seen Thomas attack anyone in this thread - I've seen him getting rightfully grumpy at sub-par code quality of the Intel uncore driver... > [...] not bothering to look up data sheets, not understanding the hardware > you're changing the driver for, etc. Why do you even bother to post the patches? Stop these personal attacks and stop insulting people why try to clean up the mess you made of a driver! Thomas found real bugs in the driver and presented a much cleaner model for representing uncore PMUs, which results in nice simplifications: 2 files changed, 139 insertions(+), 220 deletions(-) if these changes survive review and testing then they are very much 'worth it', and that fact should be apparent to you as well. Thanks, Ingo