From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1425822AbcBRJ3U (ORCPT ); Thu, 18 Feb 2016 04:29:20 -0500 Received: from mail-bn1bon0074.outbound.protection.outlook.com ([157.56.111.74]:36624 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1425290AbcBRJ3N (ORCPT ); Thu, 18 Feb 2016 04:29:13 -0500 Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=caviumnetworks.com; Date: Thu, 18 Feb 2016 10:13:07 +0100 From: Jan Glauber To: Will Deacon CC: Mark Rutland , , Subject: Re: [PATCH v3 1/5] arm64/perf: Rename Cortex A57 events Message-ID: <20160218091307.GA4566@hardcore> References: <20160215194037.GU6298@arm.com> <20160215200613.GY6298@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160215200613.GY6298@arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Originating-IP: [46.223.157.133] X-ClientProxiedBy: AM3PR06CA035.eurprd06.prod.outlook.com (10.141.192.153) To SN2PR0701MB768.namprd07.prod.outlook.com (25.160.15.146) X-Microsoft-Exchange-Diagnostics: 1;SN2PR0701MB768;2:bCZ/5Hxdu/R2qEB052v+KYQaML3mmasR0muO1FBn33muzcnxiQZsMHgiQAy5p7ATrI6dMGIdFLq4lQa7U4kMcICOyjSyiWTdEIC0rZfwF7t6cQitUvxteWTWQPkMKrsGIELE0y60x3EgIdolhLw46Q==;3:Po0zp6MgXl8NMkXJLKyQlVS9SPpj3WLITy5gu5QxTdPAu//K5gKA6iGxaXzd/YHInbT+T8OYCpQx1oaarLGiFPk8Ha1cnzJ3nxJxJqKo+PnrxR5Yib6H2FQffYqiUlB2;25:NFvlPBtoljS01uX1VSHTePvQtCJSh24Tp6xfeedEWuIdBDQ7gAa7xW/S5zVqKx06DOZPnHlz/CJdPkS3yFMoYUO2pEDon05iglgh4tUygRZZ87bgwQ7JFfJUeHBmchd9McyWegKt9NjOd1+pfjBnYugcdMBxoq3GvUyKYSilDXYul+30YA44Gm1zOvoejVRqL3B5iEhEXGagbG7p7yibs2k/rgRY5bZ/WNQ1a4umxW3F65cunsV89nqa/S6/NCNdGjwRZViY+Lhq5cKCvrxdvXpSznGH0LJW+GhdDOrhrR11z9MMBQ2MhpTpV/lRXDhh X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN2PR0701MB768; X-MS-Office365-Filtering-Correlation-Id: 253831cc-b76e-4b2c-6b93-08d33843c1da X-Microsoft-Exchange-Diagnostics: 1;SN2PR0701MB768;20:D1h1u8VIMl8+Mw+wZ3Jm/OpLOuJsHIH0B1FGoWitz7PRl1LuDq15EEUdKCAskFFYeC0pC4ksgQ6rDvuqjgT18jVGTWCxaNP5ynbgOjNR8T5telGBE8mOOeiyJKgL3ndKki04VcHZO5Y1ESLcx6blKHr3Vmdb4lPGgftcfTeFKWN7QgOeP7e+FF8ThBe1et31TZbgTmqEa3zEbG2r1icM58+WaEtnLuJ8dTMSYNgP0Z4e3aVquPmzRTL532SCtxN23G0OsA9mwOzcm1RYPeiy38KHHYMhmp1KzqX86zhjsI19YjRJ9d69oMBfRD8JZjTa2K69+M8LgjeQUcQFK24g2Wc9vVD5n4TnAnF4n34x9i5Wmppq6yXV0bPDnVjdMx4KRRyrRII3lRfTTIGyPaZmU5Zn/HWHyfHoNXVvC84qrZTeLGLjkrvAOrYwVd5Yb4tHWVkjUJODvILx4BVYkUWhkEPVRU1dH2XaHQJHhSZK5EXrtIKgQJmQ33B+w+LVfydasVTorsASiyHdS9hoNerVoXrDbZ1qzZysaGBDFeghbJdkMoZPUgDo05oFsatvSDCl8+iiiZqReAeuojS/FTYI91J7k/kbmlbOXamacOrskrI= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046);SRVR:SN2PR0701MB768;BCL:0;PCL:0;RULEID:;SRVR:SN2PR0701MB768; X-Microsoft-Exchange-Diagnostics: 1;SN2PR0701MB768;4:l5gzIg7zKt/NrvUodHy+WQfePXid7UO2IeqMTB9MDldMSCvaToLGQxeVEzs4p3SuMLINtQXnY67DimbdpK28Nc8RByIGbAVN0LTI/Fge/OV1geY2fqHRrmiCmSnzEWcuFItRFZK8BgLxnN/AjBsKtJ/nOCoLa+0g8BGOFEbZ3KcacbT0tJncpH68Tr9mg/TN7/kzQfbO2+rtWrM4QWtoIifDh3cd1vaPx+0uWxgfpk5XrBDEqfXaNe59mVy92Pys6Jv2J4qhSQr6j6o4Q/jd/uBgp33BQMSRQP0nSwH4/Zo9jzDxLHq7Ii0FAQxsyrhzOf6TTdT39P2QvJxX6U/Z87mqjJ9R55/RYeH4aWq0eAT4y5HeGCOZM3JZngB3qVMG X-Forefront-PRVS: 085634EFF4 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(24454002)(42186005)(1096002)(189998001)(47776003)(1076002)(586003)(3846002)(110136002)(5008740100001)(5001960100002)(23726003)(97756001)(83506001)(5004730100002)(2950100001)(77096005)(86362001)(33656002)(33716001)(40100003)(122386002)(92566002)(4001350100001)(4326007)(46406003)(76176999)(50986999)(2906002)(50466002)(87976001);DIR:OUT;SFP:1101;SCL:1;SRVR:SN2PR0701MB768;H:hardcore;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;SN2PR0701MB768;23:dA1OoTaZXC5ZnC7sxI7rBtKt3UFBDtvS8ZZyo1gpKPS7VcToDYBVxp3AGmkL3qYpFew+avGpHlx+gejxTHpukGKdaTD9VQOHrH71tP4eY8KAr2dIo2yQcwjL8xpt4Sho6Uot1BzfhGJ+1mjrd8ogZ/SjHKvcyHQlnsysCKXrZ8tBVWfAOm6RfvoaVzlQinPCxucKofw51iYhSnjRK34/PQN8oIpYENxpPZbJ2hVQBNduY1opXBU/mq/yDJJauOPYccyP08iKUvTNdOLS0HjZD7I3goNHdJuX/I11rh5iWPtdD0x9+V1Z1WMx73+WbwhspraWRCW5tGxyMBy/wWI7M4MJEvKXsdPKCP9vXOyTK+GqbGEcnl5ul5ohqRz7kWsBlzr70+gcW1F0LaAGPJggrmPwumoq/endfBa7+XetUtSVLc6BOzJ0qR6FE6TsJ5XfuUfqX8XslRyJAMu/IQLoNPdOEkMXF0+7LEJeX2X4tyMOnZj7NuUj+m2Nizqn1JO9DmCq176Ll1C/VSl6WHvBdVU5svKc/g7TD895M8sHd265Z0yFXCJzMlTy5/feqg9b1mYji3tH0CUnzRwDpaCKNysulZ7PbF4SjfX0AJqf1ht4uc8dYWgz1fIX721tUltNudqp8Gnyvy9O0sAYqXfsaI7Lmy7DfECY7vtwU+fdjKbhqAwuz0rNmsveVQaiLVyw59CMtu3CRBsDPbuKZExjUo1a+cEcfGbtKyPJfJKhHJPo4kt0uqKZ/oztNhr+3n7p3BC31huh/cZHNC986fjnINT1qSFVDsh5GBwTQw/hdoqdFI//8MA/bGGP8ledefWX9zkeKt3Ee51iGe19DR7IpZy7PIzLZlEYTOienlO731lxz6kGl00Q+cxRNDFmYpzDmYQL71A3z7I5hPsg1r8uqQ== X-Microsoft-Exchange-Diagnostics: 1;SN2PR0701MB768;5:YmZN/TZkyzVxhbtDHIViBSaC9vABy4tNrSdoV8d/+MUm9F2VKk4c3QG6OUm0NW6/HKVnsSSLITI3wQ/FGkbStefX/Ys+SMrnBhxACAO3YsLP4xIbksJW3frwGzP3JoGXQrFKu8RQVKU4RxsuaabyEg==;24:I/RZ2o4pMLsPJtEFYzs3lAVRaPvOFb0GZlLBDqwZlCgc8Ahz1LuA+Gcmf/I0w2UjjhborWUoseaV+SCpvYOEEMwbgCgrz+7w2R3yEm4eEAo= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2016 09:13:24.4559 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR0701MB768 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 15, 2016 at 08:06:13PM +0000, Will Deacon wrote: > On Mon, Feb 15, 2016 at 07:40:37PM +0000, Will Deacon wrote: > > On Wed, Feb 03, 2016 at 06:11:56PM +0100, Jan Glauber wrote: > > > The implemented Cortex A57 events are not A57 specific. > > > They are recommended by ARM and can be found on other > > > ARMv8 SOCs like Cavium ThunderX too. Therefore move > > > these events to the common PMUv3 table. > > > > I can't find anything in the architecture that suggests these event > > numbers are necessarily portable between implementations. Am I missing > > something? > > Aha, I just noticed appendix K3.1 (silly me for missing it...). > > Lemme check whether or not that mandates that those encodings can't be > used for wildly different things. To me it looks like we would just have duplicated code without the patch, and at least the event types (e.g. L1D_CACHE_RD) should be identical across implementations. But I don't care too much, so please tell me if should drop the patch or keep it. thanks, Jan > Will