From: Ingo Molnar <mingo@kernel.org>
To: Dave Hansen <dave@sr71.net>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org,
dave.hansen@linux.intel.com, linux-mips@linux-mips.org,
linux-ia64@vger.kernel.org
Subject: Re: [PATCH] signals, ia64, mips: update arch-specific siginfos with pkeys field
Date: Thu, 18 Feb 2016 11:15:37 +0100 [thread overview]
Message-ID: <20160218101537.GA5540@gmail.com> (raw)
In-Reply-To: <20160217181703.E99B6656@viggo.jf.intel.com>
* Dave Hansen <dave@sr71.net> wrote:
>
> This fixes a compile error that Ingo was hitting with MIPS when the
> x86 pkeys patch set is applied.
>
> ia64 and mips have separate definitions for siginfo from the
> generic one. Patch them to have the pkey fields.
>
> Note that this is exactly what we did for MPX as well.
>
> Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
> Cc: linux-mips@linux-mips.org
> Cc: linux-ia64@vger.kernel.org
> ---
>
> b/arch/ia64/include/uapi/asm/siginfo.h | 13 +++++++++----
> b/arch/mips/include/uapi/asm/siginfo.h | 13 +++++++++----
> 2 files changed, 18 insertions(+), 8 deletions(-)
This solved the MIPS and IA64 build problems, but there's still one bug left: UML
does not build:
/home/mingo/tip/mm/gup.c: In function ‘check_vma_flags’:
/home/mingo/tip/mm/gup.c:456:2: error: implicit declaration of function ‘arch_vma_access_permitted’ [-Werror=implicit-function-declaration]
if (!arch_vma_access_permitted(vma, write, false, foreign))
[...]
Please send a delta patch for this too.
Thanks,
Ingo
next prev parent reply other threads:[~2016-02-18 10:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-17 18:17 [PATCH] signals, ia64, mips: update arch-specific siginfos with pkeys field Dave Hansen
2016-02-18 10:15 ` Ingo Molnar [this message]
2016-02-18 20:20 ` [tip:mm/pkeys] signals, ia64, mips: Update " tip-bot for Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160218101537.GA5540@gmail.com \
--to=mingo@kernel.org \
--cc=dave.hansen@linux.intel.com \
--cc=dave@sr71.net \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-mm@kvack.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).