From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1425319AbcBRKPo (ORCPT ); Thu, 18 Feb 2016 05:15:44 -0500 Received: from mail-wm0-f53.google.com ([74.125.82.53]:37196 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1425184AbcBRKPl (ORCPT ); Thu, 18 Feb 2016 05:15:41 -0500 Date: Thu, 18 Feb 2016 11:15:37 +0100 From: Ingo Molnar To: Dave Hansen Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, dave.hansen@linux.intel.com, linux-mips@linux-mips.org, linux-ia64@vger.kernel.org Subject: Re: [PATCH] signals, ia64, mips: update arch-specific siginfos with pkeys field Message-ID: <20160218101537.GA5540@gmail.com> References: <20160217181703.E99B6656@viggo.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160217181703.E99B6656@viggo.jf.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Dave Hansen wrote: > > This fixes a compile error that Ingo was hitting with MIPS when the > x86 pkeys patch set is applied. > > ia64 and mips have separate definitions for siginfo from the > generic one. Patch them to have the pkey fields. > > Note that this is exactly what we did for MPX as well. > > Signed-off-by: Dave Hansen > Cc: linux-mips@linux-mips.org > Cc: linux-ia64@vger.kernel.org > --- > > b/arch/ia64/include/uapi/asm/siginfo.h | 13 +++++++++---- > b/arch/mips/include/uapi/asm/siginfo.h | 13 +++++++++---- > 2 files changed, 18 insertions(+), 8 deletions(-) This solved the MIPS and IA64 build problems, but there's still one bug left: UML does not build: /home/mingo/tip/mm/gup.c: In function ‘check_vma_flags’: /home/mingo/tip/mm/gup.c:456:2: error: implicit declaration of function ‘arch_vma_access_permitted’ [-Werror=implicit-function-declaration] if (!arch_vma_access_permitted(vma, write, false, foreign)) [...] Please send a delta patch for this too. Thanks, Ingo