From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1426324AbcBRKe1 (ORCPT ); Thu, 18 Feb 2016 05:34:27 -0500 Received: from mail-wm0-f53.google.com ([74.125.82.53]:37734 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1425406AbcBRKeY (ORCPT ); Thu, 18 Feb 2016 05:34:24 -0500 Date: Thu, 18 Feb 2016 11:34:20 +0100 From: Ingo Molnar To: Borislav Petkov Cc: Tony Luck , linux-kernel@vger.kernel.org, Thomas Gleixner , "H. Peter Anvin" , Linus Torvalds , Andrew Morton , Peter Zijlstra Subject: Re: [PATCH v11 3/4] x86, mce: Add __mcsafe_copy() Message-ID: <20160218103420.GA11011@gmail.com> References: <20160218082107.GA17851@gmail.com> <20160218102959.GD3694@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160218102959.GD3694@pd.tnic> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Borislav Petkov wrote: > On Thu, Feb 18, 2016 at 09:21:07AM +0100, Ingo Molnar wrote: > > > +#ifndef CONFIG_UML > > > > Why is this UML quirk needed? No other memcpy functions have it. Theoretically UML > > could introduce the notion of #MC interruption. > > https://lkml.kernel.org/r/56B7AEEE.5070504@nod.at Does the build fail - or is it just an unused function? If the latter then I'd rather leave the #ifdef out. Thanks, Ingo