From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946233AbcBRNgN (ORCPT ); Thu, 18 Feb 2016 08:36:13 -0500 Received: from mx2.suse.de ([195.135.220.15]:57787 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1425356AbcBRNgL (ORCPT ); Thu, 18 Feb 2016 08:36:11 -0500 Date: Thu, 18 Feb 2016 14:36:08 +0100 From: Borislav Petkov To: Alexander Kuleshov Cc: Ingo Molnar , Thomas Gleixner , "H . Peter Anvin" , x86@kernel.org, Andy Lutomirski , Alexander Popov , Denys Vlasenko , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] x86/head64: no need to define early_idt_ripmsg only if CONFIG_KALLSYMS=n Message-ID: <20160218133608.GC28860@pd.tnic> References: <1455782295-3877-1-git-send-email-kuleshovmail@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1455782295-3877-1-git-send-email-kuleshovmail@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 18, 2016 at 01:58:15PM +0600, Alexander Kuleshov wrote: > We have definition of the early_idt_ripmsg which represents string header > for the output of the kernel symbols during early exception. But the > header with kernel symbols will be printed in a case if the CONFIG_KALLSYMS=y. And this is a problem because... ? Also, try to search how many distros and configs enable KALLSYMS. That might clear some uncertainties when deciding to add one more ifdef to an already hard to read code. -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --