From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946281AbcBRNpi (ORCPT ); Thu, 18 Feb 2016 08:45:38 -0500 Received: from mail-bn1on0074.outbound.protection.outlook.com ([157.56.110.74]:15524 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S965313AbcBRNpg (ORCPT ); Thu, 18 Feb 2016 08:45:36 -0500 X-Greylist: delayed 16330 seconds by postgrey-1.27 at vger.kernel.org; Thu, 18 Feb 2016 08:45:36 EST Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=caviumnetworks.com; Date: Thu, 18 Feb 2016 14:45:20 +0100 From: Jan Glauber To: Will Deacon CC: Mark Rutland , , Subject: Re: [PATCH v3 1/5] arm64/perf: Rename Cortex A57 events Message-ID: <20160218134520.GC2648@hardcore> References: <20160215194037.GU6298@arm.com> <20160215200613.GY6298@arm.com> <20160218091307.GA4566@hardcore> <20160218112429.GC8011@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160218112429.GC8011@arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Originating-IP: [88.66.101.161] X-ClientProxiedBy: AM2PR09CA0007.eurprd09.prod.outlook.com (25.161.22.145) To BLUPR0701MB755.namprd07.prod.outlook.com (10.141.252.21) X-Microsoft-Exchange-Diagnostics: 1;BLUPR0701MB755;2:h5+ilO8+umvv4vVCHrnzOVZPSble68pnCdsmfgIgfy59Rl6vyvoDJfjOBnVyX9gHsXc7XyNwlEr++mXeUPABi098b9u6cXKSWCQg+AjGpQEgvbnL3LNz2LkCa+o+ZJFHOLuqa6mAVHG+SBd6HGSRLA==;3:UwrRR/KfF6VyjMAC2v9p/XoRy7FV1F0+fHlZn7S85wZ6L8sMRYBhugq9zQZhLbj1oYqoxNGDxBC8QIE3tEEY/Oi09roLQ6iFDQyd5qwFvUtAIqgL9cbApA6GSRQneXTm;25:popPf3Zvj4TOyZJCJAjx5Y9Wp+Yi04mr4vbRW27pn6gAG4S3G6uobqToauCBceqnwglpJObV5HmJ8jyA1IpSfgN+F0MZhtrDgOeb4ItZrnxv+UnpSkuZuSnljyOIYdXrJonrZ0CP54Z34PyLF3LGrwEBe/c+JheUfaCWUYcyCcKzhewWFjz1nmbnnAzsz9+0CETrqrPOsns+q1+bV5Tt2AqK0rOEWtyvh24mCosXYL5CPqjq+3wT6W0LjuKgwlgcT0v/FG5uL51bFp96N3qAM92O81/p5KovLTsZPYD9FGLvl0yGZTWs1IxLjzpIh2CM X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0701MB755; X-MS-Office365-Filtering-Correlation-Id: c554c183-e310-4ecb-6155-08d33869c6ac X-Microsoft-Exchange-Diagnostics: 1;BLUPR0701MB755;20:aUtBiFeXTq4sCZqhGY7MJ+N+9cWqETsfrC0Hlq3oQGlE9a+OZlxJAkj1vRNBYIa4RuI+84y7jKZWeo40/2o3ADhGHokAa9WCzEPcfeZJP/kwGv41v4EreDeTRhWB6zk8s+q4rCI3W+nOjS8j3YDIYClm9k6gSMQQL0/hfWusBXIy39FhP6EtwVfwrCmpRuUAnO6WSv9r7UxlC0Wj4wg6xxGyUHBTX3P2+oVEuRxVxvyw5hWtTiEbCpK0YPcPBGcEhGs0XUQmHUnBOR61UquvGJTbISpQNZfapTUDR6PF1RqSrfD50hKqMj+YysdH7ajmSSlmMmBR22VB+eVRKEm/KuN2csncrjGcLdJ2w5vfysflLi1WVe/+D6KS7lOJ8YJYoEq0I80wMUHQqloVmjyYg/L9CirVn3ScXRHhI60uNS1Jh+DO7e5PkniC56vttv7WW23Mol1p3Zb9Ap4t+WSHc8S+qQzRtilBYPBzj8bSCWjTC/Mi4myG2c53Oe3M+eJwqAo294qAfkc0lPYhSI+9fneFanEi3AEysEqLIPUam36YxWOeLDe3c5+AeXeEzKSbObtYz5zhCWtsD8ENnMPGNzsHZesbwdoQr7zK05+2FwE= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001);SRVR:BLUPR0701MB755;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0701MB755; X-Microsoft-Exchange-Diagnostics: 1;BLUPR0701MB755;4:wvFnPVwa+cuazcuFMSQnBxbhITiQh6tJvx6LXReBQdR1vUngP5kO0Kw6hSdCP0NKhNm52Z5N4nKpmeqMKluKIep+m+3sHYtKQWhZzZwIZ56yoK2c0gdKbJ9YC9j5NHQ4JgV5xj4bhNxY97KDrNwTpPudr8NaexLdx8AWZcYsTWHrAArp0OtQ8w///1HadFmkBYw0RMVJtUsHuLH4rzDfYHjZ9JpoQe9EQnl1FnkgYQYCNRLZJtuRx8x1n57xvcGJR04A56vbIXFO1CxjIRXZ317iqKq3YpTLCuamuHzlJbtupsOC5cj1Q9vnsYNzjI6Q23e7bIg2v7lfwIpdZYrjq6PE3lC8A4+1agMg6twkKLgt2+DPptxQ0HjP08PBXZ+q X-Forefront-PRVS: 085634EFF4 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(24454002)(97756001)(4326007)(5004730100002)(5008740100001)(2906002)(54356999)(76176999)(33716001)(50986999)(66066001)(40100003)(33656002)(122386002)(42186005)(46406003)(87976001)(5001960100002)(6116002)(4001350100001)(47776003)(1076002)(50466002)(2950100001)(189998001)(586003)(77096005)(1096002)(92566002)(3846002)(83506001)(86362001)(110136002)(23726003);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR0701MB755;H:hardcore;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BLUPR0701MB755;23:wrucFcienqOLxYBrshIuuNcGWIYXeA+pIFGS/dn6?= =?us-ascii?Q?A+uVhZwsAS87d0CBwM7nP99spPBvXUntWeDRfJOQy6VEaKmC5dnAn9/HMIMt?= =?us-ascii?Q?T2PK3v9/gl4Du0+ospgIjytv2PWdAcdEh4mE/00csWVqioCDjNntGwEU+U2b?= =?us-ascii?Q?eJB4EkrOGcIrR/PF/VntGVCro1wYUBCaKjXA+/S1Eok+8KAQCcIul/1Z98iJ?= =?us-ascii?Q?r92m4RpSTUi8UZsPUToMY6+WcgsTLByaumDDsFA0lXN4XRR+4FYXuZgXU06x?= =?us-ascii?Q?fxCT3w0qJGCEOzI/aPzU2FLRVE2nL+GSxu6q4UGr6AHHUj9+N+bstmxjVKm+?= =?us-ascii?Q?CCmeLfOW4pb7+mm75NsxeTY41d2MAcLIpUE1ZRYJ0EVr3cHyhHNCOjgzjtBt?= =?us-ascii?Q?Xb/pWpn5c+FkT/TYK283BtmMwR9lsif020WEnkjCt23Uozd8KfjrLaeTyphA?= =?us-ascii?Q?iCOdNFKvgXEnIJtOwB3uLIeblFolFGzWNYIK05iNt6A+ad3gXAMeH7P6MFFD?= =?us-ascii?Q?XhjWSmFPlwrRKnmUT+f+Pd3PNTDMxvdq4sdaun5ClulmAfR+F2aBOQBWEouu?= =?us-ascii?Q?+lwufh+GRlA3DfVpJc8862wjJKIefWJBGLM48Qrz3XvOYKprtjxhOOAePnCP?= =?us-ascii?Q?2FMhMIvsjYNlwPWoxHkYcvavH7wxHOt0+w4+trtALObmSY/jnrmjpOT6SbE1?= =?us-ascii?Q?dJaIVyo2vDng9XDrgTiXGGGSWYEM1N/I129U+1BnfUwHzObOxk1eAMBaTjML?= =?us-ascii?Q?9QZGk53mBihB3D6sZZU9k8XwvNmaidQCo8b6d6S6OlUiAV+3loSs/yswdwtM?= =?us-ascii?Q?lfsQ/JF/WgRhfcjJWhJgxjjUqNNuk3hIcJJz/G+8MY1fqI4Sfyas4UpmY6Cd?= =?us-ascii?Q?LjUnQwpmJRNt9LZlezNYjHlSVrPdGU/IghpYDimYiNU9BLDtKhsbocIQbH0O?= =?us-ascii?Q?GiQgvnp51Mrga44XUciaaSRRP5dUFd88qGWWZK616w=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BLUPR0701MB755;5:pjyF83/JzpyI2ZL4essEQ7OpGnMLNrdo0uTxKawpAeEq+9OwuBU+rUsXubOpK2XtOIUG8+X8jjZK1FS+16eKrd/9rRtltAB7XwDZa6Rc3btci1gMrLE6oKkFW3ziUqcITZ4LvaF1WLIH1kjNWL83aQ==;24:1utiQBCgpOdwHtGCqIxRwHEH0Wi2i7S8NPV9KtoYf3iodXPOz3anU7RAVbZbcfZ//bpaKzQCOJQFC56lC/9u6NEpsu8b2bAfhH/aiEd/G1c= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Feb 2016 13:45:33.6997 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB755 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 18, 2016 at 11:24:29AM +0000, Will Deacon wrote: > On Thu, Feb 18, 2016 at 10:13:07AM +0100, Jan Glauber wrote: > > On Mon, Feb 15, 2016 at 08:06:13PM +0000, Will Deacon wrote: > > > On Mon, Feb 15, 2016 at 07:40:37PM +0000, Will Deacon wrote: > > > > On Wed, Feb 03, 2016 at 06:11:56PM +0100, Jan Glauber wrote: > > > > > The implemented Cortex A57 events are not A57 specific. > > > > > They are recommended by ARM and can be found on other > > > > > ARMv8 SOCs like Cavium ThunderX too. Therefore move > > > > > these events to the common PMUv3 table. > > > > > > > > I can't find anything in the architecture that suggests these event > > > > numbers are necessarily portable between implementations. Am I missing > > > > something? > > > > > > Aha, I just noticed appendix K3.1 (silly me for missing it...). > > > > > > Lemme check whether or not that mandates that those encodings can't be > > > used for wildly different things. > > > > To me it looks like we would just have duplicated code without the patch, > > and at least the event types (e.g. L1D_CACHE_RD) should be identical > > across implementations. > > > > But I don't care too much, so please tell me if should drop the patch or > > keep it. > > Tell you what then -- how about we simply rename those to ARMV8_IMPDEF_* > instead of ARMV8_A57_*? That way, we can easily identify them as distinct > from the architected events if we need to in future. Sounds good. I'll refresh and re-post the whole series then. Jan > Will