From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1426413AbcBRN6r (ORCPT ); Thu, 18 Feb 2016 08:58:47 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:45208 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1425486AbcBRN6Y (ORCPT ); Thu, 18 Feb 2016 08:58:24 -0500 Date: Thu, 18 Feb 2016 13:57:51 +0000 From: Mark Brown To: Jianqun Xu Cc: Heiko Stuebner , robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, jwerner@chromium.org, catalin.marinas@arm.com, will.deacon@arm.com, sboyd@codeaurora.org, linus.walleij@linaro.org, sjoerd.simons@collabora.co.uk, huangtao@rock-chips.com, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Message-ID: <20160218135751.GE7129@sirena.org.uk> References: <1455762983-29980-1-git-send-email-jay.xu@rock-chips.com> <1455762983-29980-3-git-send-email-jay.xu@rock-chips.com> <20160218094108.GA7129@sirena.org.uk> <2327512.KAqs6H56Km@phil> <56C5959D.3030806@rock-chips.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vv4Sf/kQfcwinyKX" Content-Disposition: inline In-Reply-To: <56C5959D.3030806@rock-chips.com> X-Cookie: Are you a turtle? User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v2.1 2/4] spi: rockchip: add bindings for rk3399 spi X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --vv4Sf/kQfcwinyKX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Feb 18, 2016 at 05:57:49PM +0800, Jianqun Xu wrote: > I'm a little confuse, I have upstreamed rockchip-i2s, and the i2s driver set > the compatible like: > - compatible: should be one of the followings > - "rockchip,rk3066-i2s": for rk3066 > - "rockchip,rk3188-i2s", "rockchip,rk3066-i2s": for rk3188 > - "rockchip,rk3288-i2s", "rockchip,rk3066-i2s": for rk3288 > - "rockchip,rk3399-i2s", "rockchip,rk3066-i2s": for rk3399 > and the driver only has > static const struct of_device_id rockchip_i2s_match[] = { > { .compatible = "rockchip,rk3066-i2s", }, > {}, > }; > The spi of rk3399 as same as rk3066, rk3188, rk3288, like i2s, if they are > keep different rules ? No, that's just something that got missed in review and which should be fixed. --vv4Sf/kQfcwinyKX Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWxc3eAAoJECTWi3JdVIfQPn0H/1pS4pSP4GUrIc3s5JcMgdb8 A1r+80mR2QyxZ2sjmslLv63Q4zSbMJSqRMC/RVxpPFZ4LirQgduYB+ihu+nFwL6S i7lANd9ruQZlOek9z7J9WzvhLeu4VMVdo2xI2TdgmQz+98BBUJYno5FdtIWiooWB csR5iGR3B7fJ9tV6wRI/2/a6sTchYGKK9TTGDPJuY0NNJeLmMhFB9+AWRM+P9a3T BUtaeKx2dWfd/ze9fh54H7wAlt2LncLMYZgvPbfhmCui++z6PrASjxIcx85rlpPb TckG56n+Xhx5CkxR9iT+6QxpFDSnmTLw6kD+Umz/cJ2NLshD40xqXiIbWF8tuNk= =r/QX -----END PGP SIGNATURE----- --vv4Sf/kQfcwinyKX--