From: Thierry Reding <thierry.reding@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "J . German Rivera" <German.Rivera@freescale.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] staging: fsl-mc: Do not allow building as a module
Date: Thu, 18 Feb 2016 15:02:30 +0100 [thread overview]
Message-ID: <20160218140230.GC3941@ulmo.nvidia.com> (raw)
In-Reply-To: <1455542543-21303-1-git-send-email-thierry.reding@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 999 bytes --]
On Mon, Feb 15, 2016 at 02:22:22PM +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> This driver uses functionality (MSI IRQ domain) whose symbols aren't
> exported, and hence the modular build fails. While arguably there might
> be reasons to make these symbols available to modules, that change would
> be fairly involved and the set of exported functions should be carefully
> auditioned. Fix the build failure for now by marking the driver boolean.
>
> Cc: J. German Rivera <German.Rivera@freescale.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> drivers/staging/fsl-mc/bus/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Sorry for being pushy, but this has had allmodconfig builds broken in
linux-next for a couple of days now. The driver has been marked BROKEN
now in linux-next to remedy that, but having proper fixes seems better
than that.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-02-18 14:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-15 13:22 [PATCH 1/2] staging: fsl-mc: Do not allow building as a module Thierry Reding
2016-02-15 13:22 ` [PATCH 2/2] staging: fsl-mc: Avoid section mismatch Thierry Reding
2016-02-18 14:02 ` Thierry Reding [this message]
2016-02-19 4:36 ` [PATCH 1/2] staging: fsl-mc: Do not allow building as a module Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160218140230.GC3941@ulmo.nvidia.com \
--to=thierry.reding@gmail.com \
--cc=German.Rivera@freescale.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).