From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756673AbcBROCg (ORCPT ); Thu, 18 Feb 2016 09:02:36 -0500 Received: from mail-pf0-f169.google.com ([209.85.192.169]:34917 "EHLO mail-pf0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751271AbcBROCf (ORCPT ); Thu, 18 Feb 2016 09:02:35 -0500 Date: Thu, 18 Feb 2016 15:02:30 +0100 From: Thierry Reding To: Greg Kroah-Hartman Cc: "J . German Rivera" , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] staging: fsl-mc: Do not allow building as a module Message-ID: <20160218140230.GC3941@ulmo.nvidia.com> References: <1455542543-21303-1-git-send-email-thierry.reding@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ZmUaFz6apKcXQszQ" Content-Disposition: inline In-Reply-To: <1455542543-21303-1-git-send-email-thierry.reding@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ZmUaFz6apKcXQszQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Feb 15, 2016 at 02:22:22PM +0100, Thierry Reding wrote: > From: Thierry Reding >=20 > This driver uses functionality (MSI IRQ domain) whose symbols aren't > exported, and hence the modular build fails. While arguably there might > be reasons to make these symbols available to modules, that change would > be fairly involved and the set of exported functions should be carefully > auditioned. Fix the build failure for now by marking the driver boolean. >=20 > Cc: J. German Rivera > Cc: Greg Kroah-Hartman > Signed-off-by: Thierry Reding > --- > drivers/staging/fsl-mc/bus/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Sorry for being pushy, but this has had allmodconfig builds broken in linux-next for a couple of days now. The driver has been marked BROKEN now in linux-next to remedy that, but having proper fixes seems better than that. Thierry --ZmUaFz6apKcXQszQ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJWxc72AAoJEN0jrNd/PrOho40P/jxt9XLiyZptRs/OwcojzPUR zfRN+vUPa97nss/lBY53QNAdq3CQ8NBPHgpfDgJwkEmd4QYbqHfvIxtJGoXpYZRU kdd5VLDcix1liukpQgtSdPCjyMpZPxUzBXeZcIHq7/qTl0wiIlxtGNXf3XZMi95H gk9TskEEslvQqXId8zlN+EuAkyayQJqK2EwBwl6+B21IIQPYplzC169fiJZeKK9s OPUO2dA4HXUqbEcJDDeH1EbH7n/sIeIR2QwsnnUJNLaAZ35NyqfkJ7Hwge2Qyn3B SgZddSYUqDpBj4tPq8AZE6YDdegX5jNh2TELP3WItVOvAKIdIGSwSAg+376khSt5 LQTKt5bYs6qQxOOhfchg5fcwrQb1sEciS4Ko6HyfySt18JZxTcO4h14p+dZF03gz rdjHP/xrtPyTw+vSYv10Cfx/RYsBh9jcwyh+oZH4MoYmRZLrB5Ae2wd7xOdxTjLn RALO2BdpNOVGwLwfdCiSF9cXMGIROflacrHTTvgqAEzReAABu7x0i4QBJGM2d3zK JzNQJbx35Be+QGCEJMWYCjhVYSXers4MR2w0+LcjFm/l1iTxCXPyaRJ+uUzsIr4/ rbzZJg6TfM+SaDteKW/Ve+PCf8HMF3wWHMUTbXBgbkMsu6VItoZGdVlCPgUEepnE 4qFe96E2Hl49H1ZZdU9a =FX+7 -----END PGP SIGNATURE----- --ZmUaFz6apKcXQszQ--