From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1426409AbcBROl3 (ORCPT ); Thu, 18 Feb 2016 09:41:29 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:49154 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1424150AbcBROl0 (ORCPT ); Thu, 18 Feb 2016 09:41:26 -0500 Date: Thu, 18 Feb 2016 06:41:24 -0800 From: Christoph Hellwig To: Tejun Heo Cc: Andy Shevchenko , Mika Westerberg , linux-block@vger.kernel.org, Jens Axboe , James Bottomley , "Martin K . Petersen" , "linux-kernel@vger.kernel.org" , linux-ide@vger.kernel.org, linux-scsi Subject: Re: [PATCH 5/7] ahci: Convert driver to use modern PM hooks Message-ID: <20160218144124.GA8145@infradead.org> References: <1455785657-22924-1-git-send-email-mika.westerberg@linux.intel.com> <1455785657-22924-6-git-send-email-mika.westerberg@linux.intel.com> <20160218131246.GF6479@mtj.duckdns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160218131246.GF6479@mtj.duckdns.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 18, 2016 at 08:12:46AM -0500, Tejun Heo wrote: > On Thu, Feb 18, 2016 at 12:45:05PM +0200, Andy Shevchenko wrote: > > > + .driver.pm = &ahci_pci_pm_ops, > > > > Please, do this in several assignments, since to support older compilers. > > Can you please elaborate? That's a single assignment. Are there > compilers which can't do that? Old gcc (I think 4.4 is the last one) needs: .driver = { .pm = &ahci_pci_pm_ops, },