From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1947143AbcBRRbt (ORCPT ); Thu, 18 Feb 2016 12:31:49 -0500 Received: from quartz.orcorp.ca ([184.70.90.242]:50847 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1945930AbcBRRbr (ORCPT ); Thu, 18 Feb 2016 12:31:47 -0500 Date: Thu, 18 Feb 2016 10:31:40 -0700 From: Jason Gunthorpe To: Jarkko Sakkinen Cc: Peter Huewe , tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [tpmdd-devel] [PATCH] tpm_crb: fix bad name pointer usage with struct resource Message-ID: <20160218173140.GA5899@obsidianresearch.com> References: <1455668874-13261-1-git-send-email-jarkko.sakkinen@linux.intel.com> <20160217045219.GA26086@obsidianresearch.com> <20160217093623.GA9831@intel.com> <20160217142016.GA6951@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160217142016.GA6951@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 17, 2016 at 04:20:16PM +0200, Jarkko Sakkinen wrote: > Maybe for the release the safest bet would be anyway explicitly not > use the name field? That's the safest bet given the release time > frame. nulling it in the acpi paths of tis and crb, if you know those are broken seems good for a rc. I haven't looked at what other options there are, I suspect it needs strdup due to how the drivers are working with acpi.. Jason