From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1948934AbcBSQNb (ORCPT ); Fri, 19 Feb 2016 11:13:31 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:34197 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1948518AbcBSQN2 (ORCPT ); Fri, 19 Feb 2016 11:13:28 -0500 Date: Fri, 19 Feb 2016 11:13:23 -0500 (EST) Message-Id: <20160219.111323.1588037348332012027.davem@davemloft.net> To: sudipm.mukherjee@gmail.com Cc: f.fainelli@gmail.com, linux-kernel@vger.kernel.org, kernel-testers@vger.kernel.org, netdev@vger.kernel.org, geert@linux-m68k.org, helmut.buchsbaum@gmail.com Subject: Re: [PATCH v2] net: phy: spi_ks8995: add dependency on GPIO From: David Miller In-Reply-To: <20160219082909.GA6312@sudip-pc> References: <1455372195-10825-1-git-send-email-sudipm.mukherjee@gmail.com> <20160216.203606.1431228679408727525.davem@davemloft.net> <20160219082909.GA6312@sudip-pc> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 19 Feb 2016 08:13:28 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sudip Mukherjee Date: Fri, 19 Feb 2016 13:59:09 +0530 > On Tue, Feb 16, 2016 at 08:36:06PM -0500, David Miller wrote: >> From: Sudip Mukherjee >> Date: Sat, 13 Feb 2016 19:33:15 +0530 >> >> > The builds of allmodconfig of s390, m68k, tilegx, tilepro is failing >> > with the error: >> > drivers/net/phy/spi_ks8995.c:477:3: error: implicit declaration of function 'gpiod_set_value' >> > drivers/net/phy/spi_ks8995.c:477:19: error: implicit declaration of function 'gpio_to_desc' ... > I think Arnd's patch is still not applied as we are still having build > failures for the implicit declarations. Or you want me to send v3 after > removing unnecessary linux/gpio.h include? It's definitely there in net-next, commit 27090cbdc345cd5fd6f6e57a8986c504c27e4d23