From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2993720AbcBTEuE (ORCPT ); Fri, 19 Feb 2016 23:50:04 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:42649 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1427241AbcBTEuC (ORCPT ); Fri, 19 Feb 2016 23:50:02 -0500 Date: Fri, 19 Feb 2016 23:50:00 -0500 (EST) Message-Id: <20160219.235000.1109030635629935367.davem@davemloft.net> To: xiyou.wangcong@gmail.com Cc: ldv@altlinux.org, xemul@parallels.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] unix_diag: fix incorrect sign extension in unix_lookup_by_ino From: David Miller In-Reply-To: References: <20160219012748.GA17251@altlinux.org> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 19 Feb 2016 20:50:01 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Cong Wang Date: Fri, 19 Feb 2016 16:21:14 -0800 > On Thu, Feb 18, 2016 at 5:27 PM, Dmitry V. Levin wrote: >> The value passed by unix_diag_get_exact to unix_lookup_by_ino has type >> __u32, but unix_lookup_by_ino's argument ino has type int, which is not >> a problem yet. >> However, when ino is compared with sock_i_ino return value of type >> unsigned long, ino is sign extended to signed long, and this results >> to incorrect comparison on 64-bit architectures for inode numbers >> greater than INT_MAX. >> >> This bug was found by strace test suite. >> >> Signed-off-by: Dmitry V. Levin >> Cc: > > Fixes: 5d3cae8bc39d ("unix_diag: Dumping exact socket core") > Acked-by: Cong Wang Applied and queued up for -stable.